[Music] Update scrubber to be consistent with the video player

RESOLVED FIXED

Status

Firefox OS
Gaia::Music
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: epang, Assigned: ivanovpavel)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, jian)

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Created attachment 832963 [details]
Music_Player_Specs.png

Pavel, I'm attached designs and specs for the now playing screen in Music.  Please let me know if you have any questions. Thanks!
Created attachment 833324 [details] [review]
patch for Gaia/master

Hey Eric, 
can you check this on your device? :)
Attachment #833324 - Flags: feedback?(epang)
Duplicate of this bug: 907176
(Reporter)

Comment 3

4 years ago
(In reply to Pavel Ivanov [:ivanovpavel] from comment #1)
> Created attachment 833324 [details] [review]
> patch for Gaia/master
> 
> Hey Eric, 
> can you check this on your device? :)

Pavel, I'm reviewing this new.  Going to send you some feedback via email soon for some changes. Thanks!
Flags: needinfo?(pivanov)
(Reporter)

Comment 4

4 years ago
Comment on attachment 833324 [details] [review]
patch for Gaia/master

Looks great, ready for review.  Thanks!!
Attachment #833324 - Flags: feedback?(epang) → feedback+
Attachment #833324 - Flags: review?(squibblyflabbetydoo)

Comment 5

4 years ago
Comment on attachment 833324 [details] [review]
patch for Gaia/master

I have a couple of minor comments on Github. r=me with those addressed. Thanks!
Attachment #833324 - Flags: review?(squibblyflabbetydoo) → review+
(Reporter)

Comment 6

4 years ago
(In reply to Jim Porter (:squib) from comment #5)
> Comment on attachment 833324 [details] [review]
> patch for Gaia/master
> 
> I have a couple of minor comments on Github. r=me with those addressed.
> Thanks!

Thanks  Jim!  Pavel can you look into Jim's comments? Thanks!
Thanks :)

Landed in master:
https://github.com/mozilla-b2g/gaia/commit/ee4ecb0b9be1dfaf2ed370562f3154fa06badd64
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(pivanov)
Resolution: --- → FIXED

Updated

4 years ago
Blocks: 950783

Updated

4 years ago
Blocks: 949016
You need to log in before you can comment on or make changes to this bug.