939139 - [Music] Update scrubber to be consistent with the video player

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Eric Pang [:epang] UX]

Attachment: Music_Player_Specs.png

Pavel, I'm attached designs and specs for the now playing screen in Music.  Please let me know if you have any questions. Thanks!

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Hey Eric, 
can you check this on your device? :)

Comment 3

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #1)
> Created attachment 833324 [details] [review]
> patch for Gaia/master
> 
> Hey Eric, 
> can you check this on your device? :)

Pavel, I'm reviewing this new.  Going to send you some feedback via email soon for some changes. Thanks!

Comment 4

[Eric Pang [:epang] UX]

Comment on attachment 833324 [details] [review]
patch for Gaia/master

Looks great, ready for review.  Thanks!!

Comment 5

[Jim Porter (:squib)]

Comment on attachment 833324 [details] [review]
patch for Gaia/master

I have a couple of minor comments on Github. r=me with those addressed. Thanks!

Comment 6

[Eric Pang [:epang] UX]

(In reply to Jim Porter (:squib) from comment #5)
> Comment on attachment 833324 [details] [review]
> patch for Gaia/master
> 
> I have a couple of minor comments on Github. r=me with those addressed.
> Thanks!

Thanks  Jim!  Pavel can you look into Jim's comments? Thanks!

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Landed in master:
https://github.com/mozilla-b2g/gaia/commit/ee4ecb0b9be1dfaf2ed370562f3154fa06badd64