Closed Bug 939144 Opened 11 years ago Closed 11 years ago

[Action Icons - Communications] Remove shadows from action icons

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Platform:
x86
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: amylee, Assigned: pivanov)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, jian)

Attachments

(5 files, 3 obsolete files)

patch for Gaia/master
46 bytes, text/x-github-pull-request
epang
: review+
epang
: feedback+
Details | Review
communications icons (use these).zip
571.10 KB, application/zip
Details
dialer.png
274.98 KB, image/png
Details
communication icons.zip
2.06 KB, application/x-zip-compressed
Details
communications.zip
645.10 KB, application/x-zip-compressed
Details 
Hi Pavel,

Please replace the action icons in this app with the ones that I'll be providing (I'll be attaching new icons to this bug). This is a blocker for Bug 939106. 

Thanks!
Attached file CallLog_Icons_1.3.zip (obsolete) — 
Hi Pavel, 

Here are the attached icons for replacement. 

Thanks!
Summary: [Action Icons - Call Log] Remove shadows from action icons → [Action Icons - Communications] Remove shadows from action icons
Attached file communications.zip (obsolete) — 
Hi Pavel,

Here are the browser icons, I've replaced them within the folder structure
gaia/apps/communications...

Thanks!
Attachment #833072 - Attachment is obsolete: true
Copy and paste isn't a good idea, I meant communications icons :)
Attached file patch for Gaia/master — 

        Attachment #8337423 -
        Flags: feedback?(epang)

    
    

    
  


  
Hey Pavel, I had to change the size of some of the icons.  Can you use these to overwrite?  thanks!
Flags: needinfo?(pivanov)

    
    

    
  


  
Hey Pavel, just noticed one of the files was corrupted, please use these.  Thanks!

        Attachment #833267 -
        Attachment is obsolete: true

        Attachment #8338676 -
        Attachment is obsolete: true

    
    

    
  
yep :) you can check it
Flags: needinfo?(pivanov)

    
    

    
  

      
      
      
      

        Attached image
          
        dialer.png
        — 
      

    


  
Hey Pavel, something is going on with the icons on the call screen.  I highlighted the issue in the screen shot, can you take a look?  I also updated a couple of icons which I will attach.
Flags: needinfo?(pivanov)

    
    

    
  


  
Hey Pavel, here are the two icons that need to be replaced. Thanks!

    
    

    
  
fixed
Flags: needinfo?(pivanov)

    
    

    
  

      
      
      
      

        Attached file
          
        communications.zip
        — 
      

    


  
Hey Pavel the icon on the call screen looks good now.  Don't be mad.. but i found another folder of images in communications... I've updated the folder here for overwriting again.  Sorry for all the updates, I'm hoping this will be the last one.
Flags: needinfo?(pivanov)

    
    

    
  
Done :)
Flags: needinfo?(pivanov)

        Attachment #8337423 -
        Flags: feedback?(epang) → feedback+

        Attachment #8337423 -
        Flags: review?(epang)

    
    

    
  
Comment on attachment 8337423 [details] [review]
patch for Gaia/master

Looks good, thanks!

        Attachment #8337423 -
        Flags: review?(epang) → review+

    
    

    
  
Landed in master:
https://github.com/mozilla-b2g/gaia/commit/49cc06b193a39335e6064895b15a3fd3c361265a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: