Closed Bug 939152 Opened 11 years ago Closed 11 years ago

[Action Icons - Shared] Remove shadows from action icons

Categories

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: amylee, Assigned: pivanov)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, jian)

Attachments

(2 files)

shared.zip
50.55 KB, application/x-zip-compressed
Details
patch for Gaia/master
46 bytes, text/x-github-pull-request
kaze
: review+
epang
: feedback+
Details | Review 
Hi Pavel,

Please replace the action icons in this app with the ones that I'll be providing (I'll be attaching new icons to this bug). This is a blocker for Bug 939106. 

Thanks!
Component: Gaia::Settings → Gaia::System
Summary: [Action Icons - Settings] Remove shadows from action icons → [Action Icons - Shared] Remove shadows from action icons
Attached file shared.zip — 
Hi Pavel,

Here are some shared icons i found that need to be updated, I've replaced them within the folder structure
gaia/shared...

Thanks!
Attached file patch for Gaia/master — 

        Attachment #8333489 -
        Flags: feedback?(epang)

    
    

    
  
Comment on attachment 8333489 [details] [review]
patch for Gaia/master

Looks good, ready for review. Thanks!

        Attachment #8333489 -
        Flags: feedback?(epang) → feedback+

        Attachment #8333489 -
        Flags: review?(kaze)

    
    

    
  
Comment on attachment 8333489 [details] [review]
patch for Gaia/master

Hi Vivien, can you help review this? Thanks!

        Attachment #8333489 -
        Flags: review?(kaze) → review?(21)

    
    

    
  
Comment on attachment 8333489 [details] [review]
patch for Gaia/master

Please re-ping Vivien for the review if my r+ is not enough.

        Attachment #8333489 -
        Flags: review?(21) → review+

    
    

    
  
(In reply to Fabien Cazenave [:kaze] from comment #5)
> Comment on attachment 8333489 [details] [review]
> patch for Gaia/master
> 
> Please re-ping Vivien for the review if my r+ is not enough.

Thanks Kaze!

    
    

    
  
Thanks again :)

Landed in master:
https://github.com/mozilla-b2g/gaia/commit/2fead1c985f28b46b122ca17b0a98be6cf7beaad
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: