Closed
Bug 939152
Opened 12 years ago
Closed 12 years ago
[Action Icons - Shared] Remove shadows from action icons
Categories
(Firefox OS Graveyard :: Gaia::System, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: amylee, Assigned: pivanov)
References
Details
(Whiteboard: ux-tracking, visual design, visual-tracking, jian)
Attachments
(2 files)
Hi Pavel,
Please replace the action icons in this app with the ones that I'll be providing (I'll be attaching new icons to this bug). This is a blocker for Bug 939106.
Thanks!
Updated•12 years ago
|
Component: Gaia::Settings → Gaia::System
Summary: [Action Icons - Settings] Remove shadows from action icons → [Action Icons - Shared] Remove shadows from action icons
Comment 1•12 years ago
|
||
Hi Pavel,
Here are some shared icons i found that need to be updated, I've replaced them within the folder structure
gaia/shared...
Thanks!
| Assignee | ||
Comment 2•12 years ago
|
||
Attachment #8333489 -
Flags: feedback?(epang)
Comment 3•12 years ago
|
||
Comment on attachment 8333489 [details] [review]
patch for Gaia/master
Looks good, ready for review. Thanks!
Attachment #8333489 -
Flags: feedback?(epang) → feedback+
| Assignee | ||
Updated•12 years ago
|
Attachment #8333489 -
Flags: review?(kaze)
Comment 4•12 years ago
|
||
Comment on attachment 8333489 [details] [review]
patch for Gaia/master
Hi Vivien, can you help review this? Thanks!
Attachment #8333489 -
Flags: review?(kaze) → review?(21)
Comment 5•12 years ago
|
||
Comment on attachment 8333489 [details] [review]
patch for Gaia/master
Please re-ping Vivien for the review if my r+ is not enough.
Attachment #8333489 -
Flags: review?(21) → review+
Comment 6•12 years ago
|
||
(In reply to Fabien Cazenave [:kaze] from comment #5)
> Comment on attachment 8333489 [details] [review]
> patch for Gaia/master
>
> Please re-ping Vivien for the review if my r+ is not enough.
Thanks Kaze!
| Assignee | ||
Comment 7•12 years ago
|
||
Thanks again :)
Landed in master:
https://github.com/mozilla-b2g/gaia/commit/2fead1c985f28b46b122ca17b0a98be6cf7beaad
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•