Closed Bug 939153 Opened 6 years ago Closed 6 years ago

[Action Icons - SMS] Remove shadows from action icons

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

x86
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: amylee, Assigned: pivanov)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, jian)

Attachments

(3 files)

Hi Pavel,

Please replace the action icons in this app with the ones that I'll be providing (I'll be attaching new icons to this bug). This is a blocker for Bug 939106. 

Thanks!
Attached file sms.zip
Hi Pavel,

Here are the sms icons, I've replaced them within the folder structure
gaia/apps/sms...

Thanks!
Attached file patch for Gaia/master
I remove few icons because we don't use them
Attachment #833468 - Flags: feedback?(epang)
Comment on attachment 833468 [details] [review]
patch for Gaia/master

Looks good Pavel!  Hey Kevin, noticed that you said it looked good to you, I've flagged you for review now, can you give us an r+?? :) Thanks!!
Attachment #833468 - Flags: review?(kgrandon)
Attachment #833468 - Flags: feedback?(epang)
Attachment #833468 - Flags: feedback+
Comment on attachment 833468 [details] [review]
patch for Gaia/master

I know we're basically twins, but I think you may have meant Rick here - so redirecting the review. :)
Attachment #833468 - Flags: review?(kgrandon) → review?(waldron.rick)
Ah - I think my mailbox was also threading these bugs under the same root email. That's probably where the confusion comes from :)
(In reply to Kevin Grandon :kgrandon from comment #6)
> Ah - I think my mailbox was also threading these bugs under the same root
> email. That's probably where the confusion comes from :)

Whoops sorry about that Kevin! :) Thanks for re assigning!
Comment on attachment 833468 [details] [review]
patch for Gaia/master

Rick is busy this week, I'm redirecting to Borja.
Attachment #833468 - Flags: review?(waldron.rick) → review?(borja.bugzilla)
(In reply to Julien Wajsberg [:julienw] from comment #8)
> Comment on attachment 833468 [details] [review]
> patch for Gaia/master
> 
> Rick is busy this week, I'm redirecting to Borja.

Thanks for letting us know and reassigning Julien!
Hi! Small doubt in Github
https://github.com/mozilla-b2g/gaia/pull/13779#issuecomment-28985112

Could you take a look? THanks!
Hey :),
sure I think that we fix this in Bug 939152
(In reply to Pavel Ivanov [:ivanovpavel] from comment #11)
> Hey :),
> sure I think that we fix this in Bug 939152
Thanks Borja! I noticed the same thing, as Pavel mentioned in comment 11 some of the icons are pulled from the shared folder :).  So the combination of the bug 939152 and this bug removes the drop shadows from the app :)
Flags: needinfo?(borja.bugzilla)
Attached image Settings' shadow
As you can see there is a shadow in the settings icon... Is there any bug filed for fixing this?
Flags: needinfo?(borja.bugzilla) → needinfo?(pivanov)
Yep Casye works on this (Bug 941620)
Flags: needinfo?(pivanov)
(In reply to Borja Salguero [:borjasalguero] from comment #13)
> Created attachment 8337566 [details]
> Settings' shadow
> 
> As you can see there is a shadow in the settings icon... Is there any bug
> filed for fixing this?

Hi Borja, looks like this icon was added to the shared folder recently.  Thanks for point it out.  I've opened a follow up bug to address is 943321.  This icon does not effect this bug, so if everything else is good can we get an r+?  Thanks!
Flags: needinfo?(borja.bugzilla)
Attachment #833468 - Flags: review?(borja.bugzilla) → review?(epang)
Comment on attachment 833468 [details] [review]
patch for Gaia/master

We resolved the issue with the options button, so we'll all good.  Let's land this!
Attachment #833468 - Flags: review?(epang) → review+
Comment on attachment 833468 [details] [review]
patch for Gaia/master

Taking a look before merging! :)
Attachment #833468 - Flags: review?(borja.bugzilla)
Comment on attachment 833468 [details] [review]
patch for Gaia/master

Now all icons are working as expected! Thanks for the quick fix! :)
Attachment #833468 - Flags: review?(borja.bugzilla) → review+
Flags: needinfo?(borja.bugzilla)
You need to log in before you can comment on or make changes to this bug.