939155 - [Action Icons - Cost Control] Remove shadows from action icons

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect, P1)

Description

[Amy Lee [:amylee] UX]

Hi Pavel,

Please replace the action icons in this app with the ones that I'll be providing (I'll be attaching new icons to this bug). This is a blocker for Bug 939106. 

Thanks!

Comment 1

[Eric Pang [:epang] UX]

Attachment: costcontrol.zip

Hi Pavel,

Here are the browser icons, I've replaced them within the folder structure
gaia/apps/costcontrol...

Thanks!

Comment 2

[Eric Pang [:epang] UX]

I meant to put cost control icons. :)

Comment 3

[Eric Pang [:epang] UX]

Attachment: costcontrol.zip

updated the cost control icons.

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 5

[Eric Pang [:epang] UX]

Attachment: config icon.zip

Hey Pavel, from my review I noticed the header is going to be white.  There currently is a white icons on the header, can you overwrite with the ones attached?  Thanks!

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

the names of the pictures were changed, but I guess that was a mistake :) you can test the PR now

Comment 7

[Eric Pang [:epang] UX]

Comment on attachment 8337424 [details] [review]
patch for Gaia/master

Thanks Pavel, ready for review.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8337424 [details] [review]
patch for Gaia/master

For PR that only swap images from one to an other, I'm fine with epang making up the review. Please make sure that the image have the exact same width/height though, otherwise it can create layout issues.

Also, this PR has one image that change the width/height from 38/38 to 45/45, was that expected?

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks Vivien :),

yes it is expected because when we scale the 30x30 image ... the 1.5x version need to be 45x45

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/093c7407abab8638aab1b7ee74470f5c71a2814b