[Action Icons - Cost Control] Remove shadows from action icons

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: amylee, Assigned: pivanov)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, jian)

Attachments

(3 attachments, 1 obsolete attachment)

50.08 KB, application/zip
Details
46 bytes, text/x-github-pull-request
vingtetun
: review+
epang
: feedback+
Details | Review | Splinter Review
1.46 KB, application/zip
Details
(Reporter)

Description

5 years ago
Hi Pavel,

Please replace the action icons in this app with the ones that I'll be providing (I'll be attaching new icons to this bug). This is a blocker for Bug 939106. 

Thanks!
Created attachment 833268 [details]
costcontrol.zip

Hi Pavel,

Here are the browser icons, I've replaced them within the folder structure
gaia/apps/costcontrol...

Thanks!
I meant to put cost control icons. :)
Created attachment 8334499 [details]
costcontrol.zip

updated the cost control icons.
Attachment #833268 - Attachment is obsolete: true
Created attachment 8337424 [details] [review]
patch for Gaia/master
Attachment #8337424 - Flags: feedback?(epang)
Created attachment 8337891 [details]
config icon.zip

Hey Pavel, from my review I noticed the header is going to be white.  There currently is a white icons on the header, can you overwrite with the ones attached?  Thanks!
Flags: needinfo?(pivanov)
the names of the pictures were changed, but I guess that was a mistake :) you can test the PR now
Flags: needinfo?(pivanov)
Comment on attachment 8337424 [details] [review]
patch for Gaia/master

Thanks Pavel, ready for review.
Attachment #8337424 - Flags: feedback?(epang) → feedback+
Attachment #8337424 - Flags: review?(21)
Comment on attachment 8337424 [details] [review]
patch for Gaia/master

For PR that only swap images from one to an other, I'm fine with epang making up the review. Please make sure that the image have the exact same width/height though, otherwise it can create layout issues.

Also, this PR has one image that change the width/height from 38/38 to 45/45, was that expected?
Attachment #8337424 - Flags: review?(21) → review+
Thanks Vivien :),

yes it is expected because when we scale the 30x30 image ... the 1.5x version need to be 45x45

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/093c7407abab8638aab1b7ee74470f5c71a2814b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.