Closed Bug 939210 Opened 11 years ago Closed 5 years ago

You can't unlinkify something in a template

Categories

(support.mozilla.org :: Knowledge Base Software, task, P5)

All
Linux

Tracking

(Not tracked)

RESOLVED WONTFIX
Future

People

(Reporter: verdi, Unassigned)

References

Details

(Keywords: good-first-bug, Whiteboard: u=user c=wiki p= s=2013.backlog)

Normally when we want to unlinkify something we add a comment next to the .com (ex. adobe<!-- -->.com). If we do this in a template, the template seems fine but when you use it in an article, the links are linkified again. 

Example: https://support.mozilla.org/en-US/kb/templateupdateflash has adobe.com and libflashplayer.so unlinkified in the Linux section. You can confirm this by displaying the template page for Linux.

But if you view https://support.mozilla.org/en-US/kb/install-flash-plugin-view-videos-animations-games with the showfor set to linux, those will be links when they shouldn't.
This doesn't show when you preview on the template.. something's broken! Calling this major since this is pretty important.
Severity: normal → major
Verdi, trying to decide if this is something we should fix immediately or whether it's okay to wait for the next sprint: In cases where Linux users have to follow instructions and the text is linked, it seems to me we won't confuse too many people and this can wait [1], if this is also happening in articles for Windows or Mac users we should probably fix it immediately as we are sending them to a random website from our instructions. Do you know if this affects Windows/Mac users?

Putting into next sprint for now.

[1] If you are on Linux and are using the command line for "tar -zxvf install_flash_player_"version"_linux."processor".tar.gz." I think it's a fair assumption that link won't throw you off.
Priority: -- → P3
Whiteboard: u=user c=wiki p= s=2013.24
Target Milestone: --- → 2013Q4
Is this a regression?
Flags: needinfo?(mverdi)
Flags: needinfo?(a.topal)
I have no idea, so I'm removing my needinfo.
Flags: needinfo?(a.topal)
(In reply to Kadir Topal [:atopal] from comment #2)
> Verdi, trying to decide if this is something we should fix immediately or
> whether it's okay to wait for the next sprint

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #3)
> Is this a regression?

I don't know if this is a regression. I don't think this is that big of a deal. You can fix this when there is time. I just filed the bug because it was pointed out.
Flags: needinfo?(mverdi)
Thanks for the feedback, Michael. Putting it into the backlog for now.
Severity: major → normal
Whiteboard: u=user c=wiki p= s=2013.24 → u=user c=wiki p= s=2013.backlog
Moving 2013Q4 bugs to the Future since we didnt care enough about them in 2014Q1.
Target Milestone: 2013Q4 → Future
Since the unintended malware links mentioned in bug 1268510 still exist for Linux, I just tested a workaround for this on stage:
Adding <b></b> instead of <!----> works because this is not being removed when the template is included in another kb article, so this can be used in affected articles for the moment.
sounds like we have a workaround, so i am setting to p5, good first bug
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.