939226 - [Action Icons - Clock] Remove shadows from action icons

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Eric Pang [:epang] UX]

Attachment: Clock-Icons.zip

Hi Pavel,

Please update the icons with the attached.

Thanks!

Comment 1

[Eric Pang [:epang] UX]

Attachment: clock.zip

Hi Pavel,

Here are the clock icons, I've replaced them within the folder structure
gaia/apps/clock...

Thanks!

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 3

[Eric Pang [:epang] UX]

Comment on attachment 8337428 [details] [review]
patch for Gaia/master

This looks good, thanks Pavel!

Comment 4

[Corey Frang [:gnarf]]

Comment on attachment 8337428 [details] [review]
patch for Gaia/master

Bouncing review flag to mike - I'm on PTO

Comment 5

[Mike Pennisi [:jugglinmike]]

Comment on attachment 8337428 [details] [review]
patch for Gaia/master

Hi Pavel,

This looks good! The CSS you modified is kind of legacy code. We're slowly converting to a formal convention in declaration ordering--would you mind re-ordering the declarations in that block according to this guide: https://github.com/necolas/idiomatic-css#declaration-order

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8337428 [details] [review]
patch for Gaia/master

Hey Mike,
as a said in https://bugzilla.mozilla.org/show_bug.cgi?id=919530#c12
it's not a good idea to do this in only few apps and if you want you can open a thread in dev-gaia about this.

anyway I just update the PR

Comment 7

[Mike Pennisi [:jugglinmike]]

Comment on attachment 8337428 [details] [review]
patch for Gaia/master

Looks good to me, Pavel! I'd be happy to merge this for you; just let me know.

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks Mike :),

I just merge the PR.

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/4295f8c2ae40d735614583b84a8325b2f5dab706