939229 - [Action Icons - Gallery] Remove shadows from action icons

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Eric Pang [:epang] UX]

Attachment: Gallery-Icons.zip

Hi Pavel,

Please update the icons with the attached.

Thanks!

Comment 1

[Eric Pang [:epang] UX]

Attachment: remove.png

Also, like in email, please replace the done icon with the string 'Done'.
As seen here: http://buildingfirefoxos.com/building-blocks/headers.html

Thanks!

Comment 2

[Eric Pang [:epang] UX]

Attachment: gallery.zip

Hi Pavel,

Here are the gallery icons, I've replaced them within the folder structure
gaia/apps/gallery...

Also, the done icon needs to be removed and replaced with the screen "Done" when i mentioned in the previous comment.

Thanks!

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Hey Eric,
can you test this PR. I also set the toolbar hight to 45px (Bug 933217)

Comment 4

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #3)
> Created attachment 833338 [details] [review]
> patch for Gaia/master
> 
> Hey Eric,
> can you test this PR. I also set the toolbar hight to 45px (Bug 933217)

Hey Pavel, looks like the toolbar height is now 45px. But the tab bar once you select an image and when editing is still 40px.  Is this something that will be updated with the refactoring once we have the specs ready?

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Good catch Eric,
I miss that part ... now the PR is updated can you check it?

Comment 6

[Eric Pang [:epang] UX]

Comment on attachment 833338 [details] [review]
patch for Gaia/master

Thanks! Looks good now, ready for review.

Comment 8

[Dale Harvey (:daleharvey)]

Comment on attachment 833338 [details] [review]
patch for Gaia/master

This is good, tested on various resolution and looks a lot nicer :) one minor nit is the commit message sans tags again

There is a bug with gallery unable to edit 2 images, thats unrelated to this, will check with david before filing

And the pick confirm icon in the top right needs updating as it is white on white, but that is true right now and of all apps, so happy for that to be fixed after

Comment 9

[Dale Harvey (:daleharvey)]

https://github.com/mozilla-b2g/gaia/commit/41ee652d3763b0be1a9775c01e446148661aafe8