150.07 KB, application/x-zip-compressed
335.81 KB, image/png
46 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
3.08 KB, application/zip
Created attachment 833078 [details] Lockscreen-Icons.zip Hi Pavel, Please update the icons with the attached. Thanks!
Hey Amy, I found that the @1.5x icons have some transparent layer over the icons can we remove it? Thanks :)
Created attachment 833283 [details] system.zip Hi Pavel, Here are the lockscreen icons, I've replaced them within the folder structure gaia/apps/system/style/lockscreen... Thanks!
Attachment #833078 - Attachment is obsolete: true
Created attachment 833326 [details] After patch screenshot Hey Eric, look at the unlock icon
Created attachment 8333864 [details] Lock icon.zip Hey Pavel, the camera icon looks good. I've attached a revised icon for the lock that should fix the problem. Thanks!
Flags: needinfo?(epang) → needinfo?(pivanov)
Created attachment 8333907 [details] After patch screenshot
Created attachment 8333945 [details] lock icons.zip Hey Pavel, sorry i updated the lock icon again (i moved it up by a pixel). Can you please replace again? Thanks!
Attachment #8333864 - Attachment is obsolete: true
done :) you can test the PR directly
Comment on attachment 8333907 [details] After patch screenshot Looks good, ready for review. Thanks!
Attachment #8333907 - Flags: feedback?(epang) → feedback+
Attachment #8333908 - Flags: review?(kaze)
Comment on attachment 8333908 [details] [review] patch for Gaia/master Hi Vivien, can you help review this on too? Thanks!
Attachment #8333908 - Flags: review?(kaze) → review?(21)
Comment on attachment 8333908 [details] [review] patch for Gaia/master I guess it means I’ve been too long for reviewing this? Please re-ping Vivien for the review if my r+ is not enough.
Attachment #8333908 - Flags: review?(21) → review+
Thanks Kaze :) Landed on master: https://github.com/mozilla-b2g/gaia/commit/76ff34f6b027e9dc47f9348f4da767d3db391df1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.