Closed
Bug 939297
Opened 11 years ago
Closed 11 years ago
Replace the debug ifdefs with DebugOnly in mozIStorageValueArray
Categories
(Toolkit :: Storage, enhancement)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: mak, Assigned: lpy)
Details
(Whiteboard: [good first bug][mentor=mak][lang=c++][qa-])
Attachments
(1 file, 1 obsolete file)
3.73 KB,
patch
|
lpy
:
review+
|
Details | Diff | Splinter Review |
in mozIStorageValueArray.idl most of the #ifdef DEBUG nsresult rv = #endif can be replaced by DebugOnly<nsresult> rv =
Assignee | ||
Comment 1•11 years ago
|
||
Hi Marco. I look through the code carefully but still have no idea in which case that '#ifdef' should not be replaced with DebugOnly, so I just replace them all. If this is wrong, I will update the patch.
Attachment #833291 -
Flags: review?(mak77)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → pylaurent1314
Reporter | ||
Updated•11 years ago
|
Summary: Replease the debug ifdefs with DebugOnly in mozIStorageValueArray → Replace the debug ifdefs with DebugOnly in mozIStorageValueArray
Reporter | ||
Comment 2•11 years ago
|
||
Comment on attachment 833291 [details] [diff] [review] bug939297.patch Review of attachment 833291 [details] [diff] [review]: ----------------------------------------------------------------- ::: storage/public/mozIStorageValueArray.idl @@ +85,1 @@ > GetInt32(idx, &v); please oneline everywhere it can fit 80 chars, so in this case mozilla::DebugOnly<nsresult> rv = GetInt32(idx, &v); I'm not going to repeat this comment, but it's valid for all of the changed rows.
Attachment #833291 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 3•11 years ago
|
||
V2 Thank you Macro
Attachment #833291 -
Attachment is obsolete: true
Attachment #8336698 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/8a9861e3b6a3
Keywords: checkin-needed
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8a9861e3b6a3
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•10 years ago
|
Whiteboard: [good first bug][mentor=mak][lang=c++] → [good first bug][mentor=mak][lang=c++][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•