939297 - Replace the debug ifdefs with DebugOnly in mozIStorageValueArray

Status: RESOLVED FIXED

(Toolkit :: Storage, enhancement)

Description

[Marco Bonardo [:mak]]

in mozIStorageValueArray.idl most of the

#ifdef DEBUG
nsresult rv =
#endif

can be replaced by

DebugOnly<nsresult> rv =

Comment 1

[Peiyong Lin[:lpy](UTC+8)]

Attachment: bug939297.patch

Hi Marco. I look through the code carefully but still have no idea in which case that '#ifdef' should not be replaced with DebugOnly, so I just replace them all. If this is wrong, I will update the patch.

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 833291 [details] [diff] [review]
bug939297.patch

Review of attachment 833291 [details] [diff] [review]:
-----------------------------------------------------------------

::: storage/public/mozIStorageValueArray.idl
@@ +85,1 @@
>        GetInt32(idx, &v);

please oneline everywhere it can fit 80 chars, so in this case

mozilla::DebugOnly<nsresult> rv = GetInt32(idx, &v);

I'm not going to repeat this comment, but it's valid for all of the changed rows.

Comment 3

[Peiyong Lin[:lpy](UTC+8)]

Attachment: bug939297.patch

V2
Thank you Macro

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/8a9861e3b6a3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8a9861e3b6a3