Replace the debug ifdefs with DebugOnly in mozIStorageValueArray

RESOLVED FIXED in mozilla28

Status

()

Toolkit
Storage
--
enhancement
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mak, Assigned: lpy)

Tracking

unspecified
mozilla28
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=mak][lang=c++][qa-])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
in mozIStorageValueArray.idl most of the

#ifdef DEBUG
nsresult rv =
#endif

can be replaced by

DebugOnly<nsresult> rv =
(Assignee)

Comment 1

4 years ago
Created attachment 833291 [details] [diff] [review]
bug939297.patch

Hi Marco. I look through the code carefully but still have no idea in which case that '#ifdef' should not be replaced with DebugOnly, so I just replace them all. If this is wrong, I will update the patch.
Attachment #833291 - Flags: review?(mak77)
(Assignee)

Updated

4 years ago
Assignee: nobody → pylaurent1314
(Reporter)

Updated

4 years ago
Summary: Replease the debug ifdefs with DebugOnly in mozIStorageValueArray → Replace the debug ifdefs with DebugOnly in mozIStorageValueArray
(Reporter)

Comment 2

4 years ago
Comment on attachment 833291 [details] [diff] [review]
bug939297.patch

Review of attachment 833291 [details] [diff] [review]:
-----------------------------------------------------------------

::: storage/public/mozIStorageValueArray.idl
@@ +85,1 @@
>        GetInt32(idx, &v);

please oneline everywhere it can fit 80 chars, so in this case

mozilla::DebugOnly<nsresult> rv = GetInt32(idx, &v);

I'm not going to repeat this comment, but it's valid for all of the changed rows.
Attachment #833291 - Flags: review?(mak77) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 8336698 [details] [diff] [review]
bug939297.patch

V2
Thank you Macro
Attachment #833291 - Attachment is obsolete: true
Attachment #8336698 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8a9861e3b6a3
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

4 years ago
Whiteboard: [good first bug][mentor=mak][lang=c++] → [good first bug][mentor=mak][lang=c++][qa-]
You need to log in before you can comment on or make changes to this bug.