939381 - Findbar for Stylish editor is broken since Firefox27

Status: VERIFIED FIXED

(WebExtensions :: General, defect)

Description

[Alice0775 White]

Build Identifier:

http://hg.mozilla.org/mozilla-central/rev/b2fab608772f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131115030203

Steps To Reproduce:
1. Install Stylish https://addons.mozilla.org/en-US/firefox/addon/stylish/ and restart
2. Set extensions.stylish.editor to 1 so that stylish editor uses normal textbox
3. about:addons > addons://list/userstyle > click "Write New Style"

Actual Results:
Findbar in editor is not displayed

Error in Error console when the editer is opened

Timestamp: 2013/11/16 13:36:42
Error: TypeError: this.browser.finder is undefined
Source File: chrome://global/content/bindings/findbar.xml
Line: 481

Timestamp: 2013/11/16 13:36:42
Error: TypeError: this._browser.finder is undefined
Source File: chrome://global/content/bindings/findbar.xml
Line: 262

Expected Results:
Findbar in editor should be displayed and functioned


Regression pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9a8916b16e6e&tochange=3734bebc9bfb
Regressed by:
  3734bebc9bfb Tom Schuster — Bug 666816 - Support findbar in e10s. r=mikedeboer

Comment 1

[Mike de Boer [:mikedeboer]]

Thanks for reporting this! I contacted Jason, the developer/ maintainer of this addon, directly with the question if I can help him make the necessary changes.

I will report back here with updates.

Comment 2

[Zulkarnain K. [:LouCypher]]

Findbar in Adblock Plus Filter window is also affected by this regression, with exactly the same error messages.

Comment 3

[Mike de Boer [:mikedeboer]]

LouCypher, thanks for reporting this! I will contact Wladimir to resolve this.

Comment 4

[Philip Chee]

addon-compat:

https://developer.mozilla.org/en-US/Firefox/Releases/27#Changes_for_addon_and_Mozilla_developers

https://developer.mozilla.org/en-US/Firefox/australis-add-on-compat-draft

Comment 5

[Alex Keybl [:akeybl]]

I find this bug confusing. Are we trying to resolve on our side, or contact all (known) impacted add-ons? If we're contacting authors, can we please make this a tech evangelism issue?

If we do plan to (or even can) change anything on our side, we'll want to resolve while 27 is still on Aurora (only 2-3 more weeks until the merge). Please keep that in mind.

Comment 6

[Mike de Boer [:mikedeboer]]

Alex, this is a tech evangelism issue. How do I tick that box?

Comment 7

[alco]

It's a TE issue, but tracking to make sure we do the needed outreach to resolve this before release.

Comment 8

[bhavana bajaj [:bajaj]]

cc'ing :jorgev so this is on his radar for outreach as discussed in channel meeting.

Comment 9

[Jason Barnabe (np)]

I exchanged some e-mails with Mike de Boer in November, but I never received any info on how to integrate the new version into Stylish.

Comment 10

[Mike de Boer [:mikedeboer]]

Attachment: PR: Adapt find-in-code to use the new Finder.jsm style interface to the find toolbar

Comment 11

[Jason Barnabe (np)]

Thanks Mike. I support older versions of Firefox (all the way back to 4.0), and I assume the new style interface will not work with older versions. Do you know how I can detect whether to use the new interface instead of the old outside of just checking the Firefox version?

Comment 12

[Tom S [:evilpie]]

You could check something like >> "finder" in gBrowser <<. If it's true, you have to use the new code.

Comment 13

[Jason Barnabe (np)]

I'm not working with a browser, I'm working with a text input, so I have no gBrowser. This is what I'm trying right now:

---
var finderJsmStyle = false;
try {
	Components.utils.import("resource://gre/modules/Finder.jsm", {});
	finderJsmStyle = true;
} catch (ex) {
	// file not available...
}
---

With a modified version of the code Mike provided, the find bar works, but I have two issues:

1. The findbar contains the text "undefined" onload
2. On load, I get "TypeError: this._browser.finder is undefined findbar.xml:262", but this doesn't seem to affect functionality.

Comment 14

[Jason Barnabe (np)]

Attachment: patched version of Stylish

A modified version of Stylish incorporating Mike's suggested changes. Seems to work with Firefox 4 through 29, except for the bugs I mention in the previous comment when using Firefox 27+.

Comment 15

[Jason Barnabe (np)]

For #2 I added

findBar._findField.value = "";

which seems to do the trick. I put up a beta at http://forum.userstyles.org/discussion/40358/stylish-for-firefox-1-4-2b1

Comment 16

[Mike de Boer [:mikedeboer]]

(In reply to Jason Barnabe (np) from comment #15)
> findBar._findField.value = "";

\o/

Comment 17

[Mike de Boer [:mikedeboer]]

Jason, can we close this issue now?

Comment 18

[Jason Barnabe (np)]

Stylish seems to work with changes now. It would be good to have this documented somewhere, but I'm satisfied.

Comment 19

[Bogdan Maris, Desktop QA]

Reproduced the initial issue on Nightly 2013-11-15, verified as fixed on Firefox 28 beta 4 (buildID: 20140218122424) using Windows 7 32bit, Ubuntu 13.10 64bit, Mac OS X 10.8.5.