939396 - onChange event is not fired on input type range for first time

Status: RESOLVED FIXED

Description

[Fahad]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131025151332

Steps to reproduce:

1. Attach an onChange handler on input type range
2. Change the value by clicking (not by dragging)
3. The handler is not called as the event is not fired.
4. Change the value again (second time) 
5. The event gets fired and handler is executed.


Actual results:

onChange is not fired for first time


Expected results:

OnChange should be fired

Comment 1

[[:Aleksej]]

Is it bug 890710?

If not, please attach a testcase.

[The Priority part of the Importance field is for the developers only.]

Comment 2

[Fahad]

It is different, I think. I have attached the fiddle URL (http://jsfiddle.net/3g9F3/).

Comment 3

[[:Aleksej]]

Thanks.

It has always been so, since bug 851090 was fixed.
no event: 2013-03-17-03-09-23-mozilla-central-firefox-22.0a1.en-US.linux-x86_64
bug: 2013-03-18-03-09-47-mozilla-central-firefox-22.0a1.en-US.linux-x86_64

Comment 4

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Jonas, now that Mounir is gone who gets these bugs?

Comment 5

[Olli Pettay [:smaug]]

jwatt might be interested in this stuff.

Comment 6

[Jonathan Watt [:jwatt]]

I implemented <input type=range>, but I don't anticipate getting to this in the few weeks before I go off on PTO.

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Jwatt maybe?

Comment 8

[Josh Matthews [:jdm]]

Would this be something you could act as a mentor for, in that case?

Comment 9

[Jonathan Watt [:jwatt]]

sure

Comment 10

[Jonathan Watt [:jwatt]]

The reason this is happening is because the code to handle 'focus' events resets the mFocusedValue member, but this happens after the 'click' event has triggered a StartRangeThumbDrag() call that updates the value (and range thumb position). Hence the focus code is unwittingly overwriting mFocusedValue with the value that the range got due to the click, and not leaving it with the value it had just before the click.

Comment 11

[Jonathan Watt [:jwatt]]

Created attachment 8335622 [details] [diff] [review]
patch

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Am I reading correctly that this has been the case since bug 851090 landed in FF22?  If that's the case and we haven't seen a ton of web breakage because of this, there's no reason to hold a release for this fix.  Please nominate for uplift if low risk and we'll go as high as we can at that time but it's quite late in the FF26 beta cycle and we're throttling down on taking speculative fixes at this point so unless there's something I'm not seeing here in terms of urgency this might only get as high as FF27.

Comment 13

[Jonathan Watt [:jwatt]]

Okay. I don't think this is super high priority, but it does seem a bit bad that script won't get notified of changes caused by a click. I'll nominate after review.

Comment 14

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c370cd2f75a

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Nominate for uplift when ready and we'll see how high up we can lift it safely.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5c370cd2f75a

Comment 17

[Jonathan Watt [:jwatt]]

Comment on attachment 8335622 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 344618
User impact if declined: script isn't notified of click changes to ranges
Testing completed (on m-c, etc.): been on m-c for a week or so
Risk to taking this patch (and alternatives if risky): pretty low
String or IDL/UUID changes made by this patch: none

Probably not for beta at this point, but I think we should definitely take it on aurora.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0d728d9700df

Comment 19

[Anthony Hughes (:ashughes) [QA]]

I don't think this needs QA verification. If anyone thinks that's a mistake please remove the [qa-] whiteboard tag and add the verifyme keyword.