939410 - JSON.parse() return incorrect error position

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Masaya Iseki[:isk](UTC+9)]

I make JSONParser::getTextPosition in bug507998 and I found JSON.parse() return incorrect error position such as below.
> js> JSON.parse("[,7,6]")
> typein:1:0 SyntaxError: JSON.parse: unexpected character at line 1 column 3 of the JSON data

Expected value is "line 1 column 2".

Comment 1

[Masaya Iseki[:isk](UTC+9)]

Attachment: bug939410.patch

The reason which failed test was simple.
JSON::advance() advance "current" pointer in spite of the error.
So I reverse "current" pointer when it has error.

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 833323 [details] [diff] [review]
bug939410.patch

Is this patch a modification to another patch that hasn't yet landed?  It should just be merged into the other patch and the combined patch posted in Bugzilla.  Or am I misunderstanding.

Comment 3

[Masaya Iseki[:isk](UTC+9)]

This patch is related to bug507998.
This patch should be merge into  bug507998's patch?

Comment 4

[Jason Orendorff [:jorendorff]]

Yes please.

Comment 5

[Nicholas Nethercote [inactive]]

I think you've merged it.  So can we close this bug report?

Comment 6

[Masaya Iseki[:isk](UTC+9)]

(In reply to Nicholas Nethercote [:njn] from comment #5)
> I think you've merged it.  So can we close this bug report?

Yes.