93949 - memory leak of versionEntry in pcertdb.c

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Jeff Hostetler]

in mozilla/security/nss/lib/certdb/pcertdb.c::SEC_OpenPermCertDB()
the variable versionEntry is not deleted under normal circumstances.

consider adding the part marked #if 1 below:

    /* check for correct version number */
    if ( handle->permCertDB ) {
	versionEntry = ReadDBVersionEntry(handle);

	if ( versionEntry == NULL ) {
	    /* no version number */
	    certdb_Close(handle->permCertDB);
	    handle->permCertDB = 0;
	} else if ( versionEntry->common.version != CERT_DB_FILE_VERSION ) {
	    /* wrong version number, can't update in place */
	    DestroyDBEntry((certDBEntry *)versionEntry);
	    PORT_Free(certdbname);
	    return(SECFailure);
	}
#if 1//begin JLH added
	else {
	    DestroyDBEntry((certDBEntry *)versionEntry);
	    versionEntry = NULL;
	}
#endif//end JLH added

    }

Comment 1

[Wan-Teh Chang]

Assigned the bug to Bob.

Comment 2

[Keyser Sose]

Marking NEW..thanks again.

Comment 3

[Robert Relyea]

Fixed in NSS 3.4