939603 - Add __slots__ support to JS objects

Status: RESOLVED FIXED

(Marketplace Graveyard :: Validation, defect)

Description

[Matt Basta [:basta]]

As it stands, every variable, identifier, and literal in every JS file in an app gets its own JS object, meaning thousands of objects are allocated for a medium-sized app. For large or extra large apps, that number could be in the millions (or, depending on how much ASM, billions).

I don't think any additional members are assigned at runtime, so we can safely add __slots__. This will dramatically improve memory usage when validating large apps and could conceivably decrease CPU churn by quite a bit as well.

Comment 1

[Matt Basta [:basta]]

https://github.com/mozilla/app-validator/commit/5b72803a59eee09bc025ac71205d92c08023edda