Fix GfxInfoBase::OperatingSystemVersion overrides

RESOLVED FIXED in mozilla28

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla28
x86
macOS
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

Posted patch Patch (v1)Splinter Review
The base class version is not const, and the const overrides are actually just hiding that function.
Attachment #8333644 - Flags: review?(bjacob)
Comment on attachment 8333644 [details] [diff] [review]
Patch (v1)

Review of attachment 8333644 [details] [diff] [review]:
-----------------------------------------------------------------

Ouch. That's what MOZ_OVERRIDE was there for. Could you sprinkle some of it?
Attachment #8333644 - Flags: review?(bjacob) → review+
https://hg.mozilla.org/mozilla-central/rev/1efac30318e4
Assignee: nobody → ehsan
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.