Closed Bug 939662 Opened 9 years ago Closed 9 years ago

Remove "using namespace mozilla::dom;" from MediaDecoder.h and fix fallout

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: kinetik, Assigned: kinetik)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

This also makes a bunch of fields on MediaDecoder protected that were unnecessarily public.
Attachment #8333651 - Flags: review?(cpearce)
Comment on attachment 8333651 [details] [diff] [review]
bug939662_v0.patch

Review of attachment 8333651 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like some changes that were destined for another patch got qref'd into this one?

::: content/media/mediasource/SourceBuffer.cpp
@@ +322,5 @@
>    }
>    // TODO: Run coded frame eviction algorithm.
>    // TODO: Test buffer full flag.
>    LOG(PR_LOG_DEBUG, ("%p Append(ArrayBuffer=%u)", this, aLength));
> +  if (mDecoder->GetResource()->BufferFull()) {

This looks like a change that was supposed to be in another patch?

::: content/media/mediasource/SourceBufferResource.cpp
@@ +151,5 @@
> +  return false;
> +}
> +
> +void
> +SourceBufferResource::MaybeDiscard()

The changes in this file look like they were destined for another patch?

::: content/media/mediasource/SourceBufferResource.h
@@ +61,5 @@
>    virtual int64_t Tell() MOZ_OVERRIDE { return mOffset; }
>    virtual void Pin() MOZ_OVERRIDE {}
>    virtual void Unpin() MOZ_OVERRIDE {}
>    virtual double GetDownloadRate(bool* aIsReliable) MOZ_OVERRIDE { return 0; }
> +  virtual int64_t GetLength() MOZ_OVERRIDE { return mDiscarded + mInputBuffer.Length(); }

The changes in this file look like they were destined for another patch?
Attachment #8333651 - Flags: review?(cpearce) → review+
Yeah, sorry, I accidentally picked them up with a cross-tree git diff.  I'll remove those changes before landing.
And because b2g can never stand to be less busted than Windows, https://tbpl.mozilla.org/php/getParsedLog.php?id=30742755&tree=Mozilla-Inbound
https://hg.mozilla.org/mozilla-central/rev/6ae587e0c6d0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.