Closed
Bug 939671
Opened 11 years ago
Closed 11 years ago
navigator.mozInputMethod.inputcontext event handler setters implemented incorrectly in MozKeyboard.js
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.3 Sprint 5 - 11/22
People
(Reporter: djf, Assigned: djf)
Details
Attachments
(1 file)
|
1022 bytes,
patch
|
xyuan
:
review+
|
Details | Diff | Splinter Review |
The handler arguments to the setter methods are ignored, and setEventHandler() is called with a single argument twice. Patch coming soon.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → dflanagan
|
|
Assignee | |
Comment 1•11 years ago
|
||
Looks like this was just a typo in the original code.
Attachment #8333690 -
Flags: review?(xyuan)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8333690 [details] [diff] [review] bug939671.patch Review of attachment 8333690 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the help :-)
Attachment #8333690 -
Flags: review?(xyuan) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/90af5f989b66
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/90af5f989b66
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 Sprint 5 - 11/22
|
||
Comment 5•11 years ago
|
||
Yeah, think this was broken when moving from XPCOM to WebIDL.
You need to log in
before you can comment on or make changes to this bug.
Description
•