939729 - With httpd.js we sometimes don't get the most recent version of the file

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
* open http://sms.gaiamobile.org:8080 in a DEBUG=1 DESKTOP=0 profile
* change things in apps/sms/js/desktop-only/contacts.js
* reload the page in Firefox

Expected:
* the changes are loaded

Actual:
* no changes are visible

These files are lazy loaded and even when shift-reloading Firefox don't try to get an updated version.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: patch v1

see also PR at https://github.com/mozilla-b2g/gaia/pull/13793
(we want a green Travis obviously)

This patch:
* makes all files expire immediately, forcing a revalidation by Firefox
* implements conditional requests with Last-Modified-Since
---
 tools/extensions/httpd/content/httpd.js |   26 ++++++++++++++++++++++----
 1 file changed, 22 insertions(+), 4 deletions(-)

Comment 2

[Julien Wajsberg [:julienw]]

This patch will probably also make it possible to remove the horrible workaround in the test-agent, where all requests go with a "?time=" parameter to force getting a new file.

Comment 3

[Julien Wajsberg [:julienw]]

Attachment: patch v2

Sorry, I left a bad comment in my previous patch. Here's a new patch with a more interesting comment.

PR is updated at https://github.com/mozilla-b2g/gaia/pull/13793

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8333771 [details] [diff] [review]
patch v2

Review of attachment 8333771 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/extensions/httpd/content/httpd.js
@@ +2813,5 @@
> +
> +      if (lastModified && ifModifiedSince && lastModified === ifModifiedSince) {
> +        dumpn(">>> file was not modified, returning a 304 code");
> +        response.setStatusLine("1.1", 304);
> +        return;

Those sounds good to me but maybe you also want to upstream those changes? http://mxr.mozilla.org/mozilla-central/find?text=&string=httpd.js

Comment 5

[Julien Wajsberg [:julienw]]

master: 2b0662ecb0e52e7b53ba80566cc1cacf442f8e57

Bug 939755 was opened to upstream this.