Closed Bug 939792 Opened 11 years ago Closed 11 years ago

Fix flaw in keyboard app object's "send" method

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Other
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v1.2 fixed)

RESOLVED FIXED
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: zcampbell, Assigned: viorela)

References

Details

Attachments

(2 files)

The keyboard app object's uses `get_active_frame()` and then tries to switch back into this frame at the end. Marionette can't do this if the active frame is a nested frame inside an app. We should change `send` to use `self.apps.displayed_app.frame` which will just get the main frame for the displayed_app and then make it the test's responsibility to switch into the nested frame after using the keyboard.
Assignee: nobody → zcampbell
Attached file github pr
Attachment #8335295 - Flags: review?(florin.strugariu)
Attachment #8335295 - Flags: review?(dave.hunt)
Attachment #8335295 - Flags: review?(bob.silverberg)
Blocks: 941004
Comment on attachment 8335295 [details] [review] github pr The code looks ok but travis is failing
Attachment #8335295 - Flags: review?(florin.strugariu) → review-
Comment on attachment 8335295 [details] [review] github pr test_browser_bookmark.py is failing
Attachment #8335295 - Flags: review?(bob.silverberg) → review-
Comment on attachment 8335295 [details] [review] github pr Rebased after some other fixes
Attachment #8335295 - Flags: review?(florin.strugariu)
Attachment #8335295 - Flags: review?(bob.silverberg)
Attachment #8335295 - Flags: review-
Attachment #8335295 - Flags: review?(florin.strugariu) → review+
Comment on attachment 8335295 [details] [review] github pr test_settings_change_keyboard_language.py is still failing
Attachment #8335295 - Flags: review?(bob.silverberg) → review-
Comment on attachment 8335295 [details] [review] github pr re tested this and works OK
Attachment #8335295 - Flags: review- → review?(bob.silverberg)
Attachment #8335295 - Flags: review?(dave.hunt)
Attachment #8335295 - Flags: review?(bob.silverberg)
Attachment #8335295 - Flags: review+
Landed on master in https://github.com/mozilla-b2g/gaia/commit/c736d91f6a1aada7b81a3d7b7df2635f2f9a655a This should be considered for v1.2, but it may be complicated.
Assignee: zcampbell → nobody
Assignee: nobody → viorela.ioia
Attachment #8338492 - Flags: review?(trifandreialin)
Attachment #8338492 - Flags: review?(florin.strugariu)
Attachment #8338492 - Flags: review?(bob.silverberg)
Attachment #8338492 - Flags: review?(andrei.hutusoru)
Comment on attachment 8338492 [details] [review] v1.2 PR: https://github.com/mozilla-b2g/gaia/pull/14065 Looks good, Viorela. Just waiting on Travis.
Attachment #8338492 - Flags: review?(bob.silverberg) → review+
Attachment #8338492 - Flags: review?(trifandreialin)
Attachment #8338492 - Flags: review?(florin.strugariu)
Attachment #8338492 - Flags: review?(andrei.hutusoru)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: