Closed
Bug 939792
Opened 11 years ago
Closed 11 years ago
Fix flaw in keyboard app object's "send" method
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(b2g-v1.2 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
b2g-v1.2 | --- | fixed |
People
(Reporter: zcampbell, Assigned: viorela)
References
Details
Attachments
(2 files)
The keyboard app object's uses `get_active_frame()` and then tries to switch back into this frame at the end.
Marionette can't do this if the active frame is a nested frame inside an app.
We should change `send` to use `self.apps.displayed_app.frame` which will just get the main frame for the displayed_app and then make it the test's responsibility to switch into the nested frame after using the keyboard.
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → zcampbell
Reporter | ||
Comment 1•11 years ago
|
||
Attachment #8335295 -
Flags: review?(florin.strugariu)
Attachment #8335295 -
Flags: review?(dave.hunt)
Attachment #8335295 -
Flags: review?(bob.silverberg)
Comment 2•11 years ago
|
||
Comment on attachment 8335295 [details] [review]
github pr
The code looks ok but travis is failing
Attachment #8335295 -
Flags: review?(florin.strugariu) → review-
Comment 3•11 years ago
|
||
Comment on attachment 8335295 [details] [review]
github pr
test_browser_bookmark.py is failing
Attachment #8335295 -
Flags: review?(bob.silverberg) → review-
Reporter | ||
Comment 4•11 years ago
|
||
Comment on attachment 8335295 [details] [review]
github pr
Rebased after some other fixes
Attachment #8335295 -
Flags: review?(florin.strugariu)
Attachment #8335295 -
Flags: review?(bob.silverberg)
Attachment #8335295 -
Flags: review-
Updated•11 years ago
|
Attachment #8335295 -
Flags: review?(florin.strugariu) → review+
Comment 5•11 years ago
|
||
Comment on attachment 8335295 [details] [review]
github pr
test_settings_change_keyboard_language.py is still failing
Attachment #8335295 -
Flags: review?(bob.silverberg) → review-
Comment 6•11 years ago
|
||
Comment on attachment 8335295 [details] [review]
github pr
re tested this and works OK
Attachment #8335295 -
Flags: review- → review?(bob.silverberg)
Updated•11 years ago
|
Attachment #8335295 -
Flags: review?(dave.hunt)
Attachment #8335295 -
Flags: review?(bob.silverberg)
Attachment #8335295 -
Flags: review+
Comment 7•11 years ago
|
||
Landed on master in https://github.com/mozilla-b2g/gaia/commit/c736d91f6a1aada7b81a3d7b7df2635f2f9a655a
This should be considered for v1.2, but it may be complicated.
status-b2g-v1.2:
--- → affected
Reporter | ||
Updated•11 years ago
|
Assignee: zcampbell → nobody
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → viorela.ioia
Assignee | ||
Comment 8•11 years ago
|
||
Attachment #8338492 -
Flags: review?(trifandreialin)
Attachment #8338492 -
Flags: review?(florin.strugariu)
Attachment #8338492 -
Flags: review?(bob.silverberg)
Attachment #8338492 -
Flags: review?(andrei.hutusoru)
Comment 9•11 years ago
|
||
Comment on attachment 8338492 [details] [review]
v1.2 PR: https://github.com/mozilla-b2g/gaia/pull/14065
Looks good, Viorela. Just waiting on Travis.
Attachment #8338492 -
Flags: review?(bob.silverberg) → review+
Updated•11 years ago
|
Attachment #8338492 -
Flags: review?(trifandreialin)
Attachment #8338492 -
Flags: review?(florin.strugariu)
Attachment #8338492 -
Flags: review?(andrei.hutusoru)
Comment 10•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•