939915 - Add switch to use Acorn instead of Spidermonkey for Travis

Status: RESOLVED FIXED

(Marketplace Graveyard :: Validation, defect, P4)

Description

[Matt Basta [:basta]]

Travis currently can't run any test which relies on JS validation because we can't install Spidermonkey on the server. Instead, we should add a `--acorn` flag which switches from spidermonkey.py to acorn.py. They work mostly the same, except acorn is slower and doesn't support certain ES6 constructs.

Some tasks:
- Add CLI switch
- Stop skipping JS tests
- Make travis install acorn
- Add skips for JS tests that use ES6 "let" stuff
- Update travis.yml to pass --acorn

This is slightly important since Jenkins doesn't test pull requests, which is the real way that most contributions end up in the validator.

Comment 1

[Matt Basta [:basta]]

https://github.com/mozilla/app-validator/commit/4901889f02b43ca3f97c8b791864af446ecc83e0