Closed Bug 939955 Opened 7 years ago Closed 7 years ago

Migrate add-on buttons to palette if the add-on bar was hidden

Categories

(Firefox :: Toolbars and Customization, defect)

x86_64
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: mconley, Assigned: Gijs)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [Australis:P2])

Attachments

(1 file)

Currently, we migrate all items from the add-on bar to the nav-bar, regardless of whether or not the add-on bar was hidden.

Some users, however, have the add-on bar hidden, but populated by many items.

That's kind of annoying - a bunch of stuff suddenly shows up in the nav-bar that the user didn't originally know or care about.

We should probably just migrate the toolbar buttons to the palette if the add-on bar was hidden.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
This took longer than I thought, but here we are. This works in my testing (although until bug 854226 is uplifted the SDK will just keep adding stuff to the navbar... 'just because').
Attachment #8338437 - Flags: review?(mconley)
Comment on attachment 8338437 [details] [diff] [review]
move widgets to palette in Australis if add-on bar was hidden pre-Australis,

Review of attachment 8338437 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! Thanks Gijs.

::: browser/components/customizableui/content/toolbar.xml
@@ +477,2 @@
>  
> +          if (!movedOut) {

Just a request for a little documentation here to list the conditions under which movedOut could be false (namely, the addon-bar was collapsed, or the widget was just too damn wide to migrate).
Attachment #8338437 - Flags: review?(mconley) → review+
With comment:

remote:   https://hg.mozilla.org/integration/fx-team/rev/6f55de739233
Whiteboard: [Australis:M?][Australis:P2] → [Australis:P2][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/6f55de739233
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P2][fixed-in-fx-team] → [Australis:P2]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.