939955 - Migrate add-on buttons to palette if the add-on bar was hidden

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Currently, we migrate all items from the add-on bar to the nav-bar, regardless of whether or not the add-on bar was hidden.

Some users, however, have the add-on bar hidden, but populated by many items.

That's kind of annoying - a bunch of stuff suddenly shows up in the nav-bar that the user didn't originally know or care about.

We should probably just migrate the toolbar buttons to the palette if the add-on bar was hidden.

Comment 1

[:Gijs (out for now; he/him)]

Attachment: move widgets to palette in Australis if add-on bar was hidden pre-Australis,

This took longer than I thought, but here we are. This works in my testing (although until bug 854226 is uplifted the SDK will just keep adding stuff to the navbar... 'just because').

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8338437 [details] [diff] [review]
move widgets to palette in Australis if add-on bar was hidden pre-Australis,

Review of attachment 8338437 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! Thanks Gijs.

::: browser/components/customizableui/content/toolbar.xml
@@ +477,2 @@
>  
> +          if (!movedOut) {

Just a request for a little documentation here to list the conditions under which movedOut could be false (namely, the addon-bar was collapsed, or the widget was just too damn wide to migrate).

Comment 3

[:Gijs (out for now; he/him)]

With comment:

remote:   https://hg.mozilla.org/integration/fx-team/rev/6f55de739233

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6f55de739233