Closed
Bug 939976
Opened 11 years ago
Closed 11 years ago
JavascriptException: TypeError: invalid 'in' operand voice lockscreen.js
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(b2g-v1.2 affected)
RESOLVED
FIXED
1.3 Sprint 6 - 12/6
Tracking | Status | |
---|---|---|
b2g-v1.2 | --- | affected |
People
(Reporter: zcampbell, Assigned: gkw)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
999 bytes,
patch
|
vingtetun
:
review+
|
Details | Diff | Splinter Review |
raise JavascriptException(message=message, status=status, stacktrace=stacktrace) JavascriptException: TypeError: invalid 'in' operand voice stacktrace: @app://system.gaiamobile.org/js/lockscreen.js, line 1062 Link to code: https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/lockscreen.js#L1062 This JavascriptException is being caught by the UI automation, for example here: https://travis-ci.org/mozilla-b2g/gaia/jobs/14155031 It is a blocker because it stops the test automation from completing that test.
Assignee | ||
Comment 1•11 years ago
|
||
I hit this while I was writing the harness for marifuzz. This affects at least master and 1.2, I think. The patch that caused this landed in bug 863318 comment 4: https://github.com/mozilla-b2g/gaia/commit/944526b951dcd3eec68bdcdf59c072142eea31ee#diff-a79cb8e42a7726b3c9a9d0624218fab0R810 Vivien, you wrote this patch, thoughts?
Reporter | ||
Comment 2•11 years ago
|
||
I don't think that patch is to blame per se, we would have noticed this much much sooner if so. Unless something is now using it incorrectly. The regression range for this is about some time in the last 7-10 days I think. Sorry I cannot be more accurate for the moment.
Comment 3•11 years ago
|
||
I think this could be related to some API changes. If |voice| is undefined now then we can throw. if ('state' in voice && voice.state == 'notSearching') { should be rewritten: if (voice && 'state' in voice && voice.state == 'notSearching')
Flags: needinfo?(21)
Assignee | ||
Comment 4•11 years ago
|
||
As suggested.
Attachment #8336592 -
Flags: review?(21) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #5) > Can you post a pull request link please? :) Is a pull request now an additional prerequisite for landing Gaia patches, other than an r+ and checkin-needed? Just wondering, because now I have to spend a bunch of time figuring out how Github's workflow works, which seems to be different from Git's, which is also different from hg's. (In the meantime, I'll try and get you a pull request)
Assignee | ||
Comment 7•11 years ago
|
||
Here's the pointer to the Github pull request, bringing forward r+.
Attachment #8338375 -
Flags: review+
Assignee | ||
Comment 8•11 years ago
|
||
Comment on attachment 8338375 [details] [diff] [review] Pointer to Gaia pull request 14056 on Github So I don't know how to use the Github integration into b.m.o correctly, sorry about that. Pointer to Github pull request is: https://github.com/mozilla-b2g/gaia/pull/14056
Attachment #8338375 -
Attachment is obsolete: true
Attachment #8338375 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 9•11 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/bb8d98559cdbec4088c0ecf9d630993378df1e4c
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.3 Sprint 6 - 12/6
You need to log in
before you can comment on or make changes to this bug.
Description
•