Closed Bug 939980 Opened 11 years ago Closed 11 years ago

Intermittent layout/reftests/text-overflow/line-clipping.html | image comparison (==), max difference: 255, number of differing pixels: 2903 followed by many more with missing ellipses

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28
Tracking Flags:
Tracking Status
firefox26 --- unaffected
firefox27 --- unaffected
firefox28 + fixed
firefox-esr24 --- unaffected

People

(Reporter: RyanVM, Assigned: heycam)

References

Details

(Keywords: intermittent-failure, regression)

Attachments

(3 files)

test screenshot
11.70 KB, image/png
Details
reference screenshot
16.37 KB, image/png
Details
Correct rendering of line-clipping.html
1.92 KB, image/png
Details
Attached image test screenshot — 
Looks like the overflow is being lost somehow on the reference cases. Roc, I can't help but notice that this started around the same time that a bunch of your recent patches hit m-c related to margins and the like. Can you please take a look?

https://tbpl.mozilla.org/php/getParsedLog.php?id=30695344&tree=Mozilla-Central

Rev4 MacOSX Lion 10.7 mozilla-central opt test reftest on 2013-11-18 04:21:56 PST for push 8c20a3bb8b81
slave: talos-r4-lion-040

04:38:43     INFO -  REFTEST TEST-START | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/text-overflow/line-clipping.html
04:38:43     INFO -  REFTEST TEST-LOAD | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/text-overflow/line-clipping.html | 4115 / 10035 (41%)
04:38:43     INFO -  REFTEST TEST-LOAD | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/text-overflow/line-clipping-ref.html | 4115 / 10035 (41%)
04:38:44     INFO -  REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/text-overflow/line-clipping.html | image comparison (==), max difference: 255, number of differing pixels: 2903
04:38:44     INFO -  REFTEST   IMAGE 1 (TEST): <see attached>
04:38:44     INFO -  REFTEST   IMAGE 2 (REFERENCE): <see attached>
04:38:44     INFO -  REFTEST INFO | Saved log: START file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/text-overflow/line-clipping.html
04:38:44     INFO -  REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
04:38:44     INFO -  REFTEST INFO | Saved log: Initializing canvas snapshot
04:38:44     INFO -  REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
04:38:44     INFO -  REFTEST INFO | Saved log: [CONTENT] RecordResult fired
04:38:44     INFO -  REFTEST INFO | Saved log: RecordResult fired
04:38:44     INFO -  REFTEST INFO | Saved log: START file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/text-overflow/line-clipping-ref.html
04:38:44     INFO -  REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
04:38:44     INFO -  REFTEST INFO | Saved log: Initializing canvas snapshot
04:38:44     INFO -  REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
04:38:44     INFO -  REFTEST INFO | Saved log: [CONTENT] RecordResult fired
04:38:44     INFO -  REFTEST INFO | Saved log: RecordResult fired
04:38:44     INFO -  REFTEST INFO | Loading a blank page
04:38:44     INFO -  REFTEST TEST-END | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/text-overflow/line-clipping.html

etc...
Attached image reference screenshot — 

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
These look more like font-size issues to me. Bug 935056 maybe?

    
    

    
  
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #6)
> These look more like font-size issues to me. Bug 935056 maybe?

What sayeth you, Cam? :)
Flags: needinfo?(cam)

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  


  
FYI, this is what that font (16px DejaVuSansMono) should look like.

    
    

    
  
I suspect this is a real regression...

          status-firefox28:
          --- → affected

          tracking-firefox28:
          --- → ?
Component: Layout → Graphics: Text
Keywords: regression
OS: Mac OS X → All
Hardware: x86_64 → All

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
Seems like a concrete layout issue, tracking.

          status-firefox27:
          --- → unaffected

          tracking-firefox28:
          ? → +

    
    

    
      
  

    
    

    
      
  

    
    

    
  
Although bug 935056 did touch nsRuleNode::SetFont, it doesn't feel like it would have caused this issue, as at most, this would cause a minimum font size not to be applied, but the reftest in question doesn't have a minimum font size set.
Flags: needinfo?(cam)

    
    

    
  
Still, I've backed it out; since we get about 4 of these oranges per day, we'll know soon whether it was the cause.

    
    

    
      
  

    
    

    
  
Comment 22 is on fx-team where the backout hasn't been merged.

    
    

    
  
It appears backing out bug 935056 fixed this bug.
Blocks: 935056
Status: NEW → RESOLVED
Closed: 11 years ago

          status-firefox28:
          affected → fixed
Component: Graphics: Text → Layout
Flags: in-testsuite+
OS: All → Mac OS X
Hardware: All → x86_64
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

    
  
Assignee: nobody → cam

          status-firefox26:
          --- → unaffected

          status-firefox-esr24:
          --- → unaffected

    
    

    
      
  

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: