Closed
Bug 939982
Opened 11 years ago
Closed 11 years ago
remove unused "edit draft message" elements and code
Categories
(Thunderbird :: Message Reader UI, defect)
Thunderbird
Message Reader UI
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 28.0
People
(Reporter: aceman, Assigned: mkmelin)
References
Details
Attachments
(1 file)
7.42 KB,
patch
|
aceman
:
review+
|
Details | Diff | Splinter Review |
It looks like patch in 562048 removed the usage of "editMessageBox" and "editMessageButton" elements as is replaced them with new notifications: http://mxr.mozilla.org/comm-central/source/mail/base/content/msgHdrViewOverlay.xul#556 <hbox id="editMessageBox" pack="start" align="center" collapsed="true" class="main-header-area"> <label id="editMessageDescription" control="editMessageButton" value="&editMessageDescription.label;"/> <button id="editMessageButton" label="&editMessageButton.label;" oncommand="MsgComposeDraftMessage()"/> </hbox> The elements and code referencing them should probably be removed (like this http://mxr.mozilla.org/comm-central/source/mail/base/content/msgHdrViewOverlay.js#2716).
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8340076 -
Flags: review?(acelists)
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Comment on attachment 8340076 [details] [diff] [review] proposed fix Review of attachment 8340076 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, it seems to me all the identifiers you are removing as unused. Also mozmill tests in /composition/ do pass. Not sure if my r+ is valid enough:)
Attachment #8340076 -
Flags: review?(acelists) → review+
Assignee | ||
Comment 3•11 years ago
|
||
I think your r+ is ok for this one. https://hg.mozilla.org/comm-central/rev/a60a4c8f9a83 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 28.0
You need to log in
before you can comment on or make changes to this bug.
Description
•