Closed Bug 940139 Opened 11 years ago Closed 10 years ago

Australis has broken back/forward buttons

Categories

(Firefox :: Toolbars and Customization, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: ehsan.akhgari, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: qawanted, Whiteboard: [Australis:P2][Australis:M?])

Attachments

(1 file)

The back button is always enabled for me even when it shouldn't be and the forward button never appears at all.
That sounds really bad. Can you try disabling all add-ons and seeing if the problem goes away?
Whiteboard: [Australis:P2][Australis:M?]
It's only happening in the window which I have had open since earlier today, new windows work as expected.  So if I restart things will probably go back to normal whether or not an add-on is at fault.
Hm, well we'll need some STR here.
Status: NEW → UNCONFIRMED
Ever confirmed: false
Lack of an STR doesn't mean that the problem doesn't exist.
Status: UNCONFIRMED → NEW
Ever confirmed: true
I believe my about:support log gives enough information for QA to try to reproduce this.
Where is this about:support log you speak of? :)
Flags: needinfo?(ehsan)
Attached file about:support
lol, sorry, I have attached this to almost all of the bugs I've filed for Australis.  ;-)  Here you are.
Flags: needinfo?(ehsan)
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #2)
> It's only happening in the window which I have had open since earlier today,
> new windows work as expected.  So if I restart things will probably go back
> to normal whether or not an add-on is at fault.

Is this session still alive? Are the add-on enabled states in your about:support correct compared to the session where this happened? Did you check the browser console for errors?

We didn't actually change how the back/fwd button operate, only their location in the navbar, so I'm a little confused as to how we rather than any add-on broke anything here if nobody else has seen it and there's no STR, so I'm very tempted to mark WFM unless this is reproducible and there's some more info.
Flags: needinfo?(ehsan)
(In reply to :Gijs Kruitbosch from comment #8)
> (In reply to :Ehsan Akhgari (needinfo? me!) from comment #2)
> > It's only happening in the window which I have had open since earlier today,
> > new windows work as expected.  So if I restart things will probably go back
> > to normal whether or not an add-on is at fault.
> 
> Is this session still alive?

Nope, sorry,  I filed this a week ago.  :-)

> Are the add-on enabled states in your
> about:support correct compared to the session where this happened?

Yes.

> Did you
> check the browser console for errors?

Probably not, but it wouldn't have worked any way since whatever was possibly logged to the console was probably *long gone* by the time I noticed this.

> We didn't actually change how the back/fwd button operate, only their
> location in the navbar, so I'm a little confused as to how we rather than
> any add-on broke anything here if nobody else has seen it and there's no
> STR, so I'm very tempted to mark WFM unless this is reproducible and there's
> some more info.

In at least one of the other bugs that I have filed, some code was assuming that the share button always existed in the toolbar and then threw when it was not, which broke something else entirely random.  I think closing this bug without at least getting QA to try to reproduce what I saw is quite premature given how important the back/forward button is.  But if you'd like to insist, I'll give up on this I guess. :(
Flags: needinfo?(ehsan)
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #9)
> > We didn't actually change how the back/fwd button operate, only their
> > location in the navbar, so I'm a little confused as to how we rather than
> > any add-on broke anything here if nobody else has seen it and there's no
> > STR, so I'm very tempted to mark WFM unless this is reproducible and there's
> > some more info.
> 
> In at least one of the other bugs that I have filed, some code was assuming
> that the share button always existed in the toolbar and then threw when it
> was not, which broke something else entirely random. 

You removed the button, which shouldn't have been removable, and then code that relied on the button not being removable broke, and that threw shit in CustomizeMode's fan. I'm not sure how that is "entirely random", but OK. Either way, we fixed quite a number of bugs since last week to do with entering/exiting Customize Mode and making it more robust.

> I think closing this
> bug without at least getting QA to try to reproduce what I saw is quite
> premature given how important the back/forward button is.  But if you'd like
> to insist, I'll give up on this I guess. :(

I've just tried reproducing it for 15 minutes, with no success. I suspect it had something to do with entering/exiting customize mode failing somehow, as that'll toggle button disabled states to ensure that the overall appearance of all the buttons is similar. I'm setting qawanted, but to be honest, with no STR, no error message, no more info than the about:support log, and nobody else reproducing anything like this since...
Keywords: qawanted
Feel free to close this bug if you want, I don't mean to debate that here.
Given the difficulty in reproducing this and lack of other reports, I think we have to call this WFM as it's not really actionable. Please reopen if you or someone else runs into it again!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: