australis menu support for social marks button

VERIFIED FIXED in Firefox 29

Status

()

Firefox
SocialAPI
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Tracking

(Blocks: 1 bug)

26 Branch
Firefox 29
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:P3])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
split out from bug 914921 to simplify the process.  Need to make the social mark button work in australis
(Assignee)

Updated

4 years ago
Blocks: 940154
(Assignee)

Updated

4 years ago
Depends on: 940820
Whiteboard: [Australis:P3]
(Assignee)

Updated

4 years ago
Depends on: 914921
(Assignee)

Comment 1

4 years ago
Created attachment 8340173 [details] [diff] [review]
make marks button work in menu panel

https://tbpl.mozilla.org/?tree=Try&rev=94c8bacd998f

This basically follows how the status button changes worked in bug 914921, though a listener would not work in this case, something to do with having a custom button and the widget wrapping on it.  Watching for the menu panel being shown is good enough as an update mechanism for this button.
Assignee: nobody → mixedpuppy
Attachment #8340173 - Flags: review?(mhammond)
Comment on attachment 8340173 [details] [diff] [review]
make marks button work in menu panel

Review of attachment 8340173 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/socialmarks.xml
@@ +150,3 @@
>            // add our resizer after the dom is ready
> +          if (!this.inMenuPanel) {
> +            let DynamicResizeWatcher = Cu.import("resource:///modules/Social.jsm", {}).DynamicResizeWatcher;

I know it wasn't before, but I think a lazy getter at the top of the file would be better.

@@ +251,5 @@
>          // pageData is passed into us. In this case, we always load the iframe
>          // and show it since the url may not be the browser tab, but an image,
>          // link, etc. inside the page. We also "update" the iframe to the
>          // previous url when it is closed.
> +        let panel = this.panel;

this is unused

@@ +304,5 @@
> +            if (!link || !link.ownerDocument || !rel || !link.href)
> +              return;
> +            if (link.rel.indexOf("icon") < 0)
> +              return;
> +    

trailing whitespace here and a few lines down
Attachment #8340173 - Flags: review?(mhammond) → review+

Updated

4 years ago
Blocks: 872617
(Assignee)

Comment 3

4 years ago
Created attachment 8348521 [details] [diff] [review]
make marks button work in menu panel

updated with comments, new try https://tbpl.mozilla.org/?tree=Try&rev=d0b206ab50d3

https://hg.mozilla.org/integration/fx-team/rev/babe33b649a3
Attachment #8340173 - Attachment is obsolete: true
Attachment #8348521 - Flags: review+
(Assignee)

Comment 4

4 years ago
> updated with comments, new try
> https://tbpl.mozilla.org/?tree=Try&rev=d0b206ab50d3

mixing bugs/patches, try is for something else, previous try was in comment 1 is for this patch
https://hg.mozilla.org/mozilla-central/rev/babe33b649a3
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29

Updated

4 years ago
QA Contact: cornel.ionce
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0

Verified fixed on latest Aurora (build ID: 20140310004003).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.