940162 - [Settings][SIM]User unable to change SIM PIN

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Steps:
1. Settings -> SIM security -> change PIN

Expected:
  Display SIM PIN change dialog

Actual: 
  Stay at SIM security page


Gaia ver: fa29c2b37b44247a3d1e133924346b22ead41cd3
Build ID: 20131110040200

From logcat:
E/GeckoConsole( 2529): [JavaScript Error: "TypeError: options is undefined" {file: "app://settings.gaiamobile.org/js/simcard_dialog.js" line: 410}]

Comment 1

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Marked as koi? because this bug is introduced by the patch of bug916059 which is koi+

Comment 2

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: pull request

Hi Fabien,

Please kindly help to review this patch. This patch are related to the patch of bug 916059 since the signature of SimPinDialog.show changed.

Comment 3

[Fabien Cazenave [:kaze]]

Comment on attachment 8334382 [details] [review]
pull request

Good catch, thanks!

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: cf1d27119bc4943552b41adc41248399b405a680

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Arthur, could you uplift this manually? We need to verify bug 940654 comment 7. Thanks!

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted cf1d27119bc4943552b41adc41248399b405a680 to:
v1.2: 5b1920988fb8bdd7bd82ec3029910fda15b1a5c9

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Clear ni per comment 6.

Comment 9

[Roland Kunkel [:RolandK]]

Verified as fixed for both 1.2 and 1.3 builds. User is able to set, reset, and change their SIM pin under Settings > SIM security.

1.2 Environmental Variables:
Device: Buri v1.2 COM RIL
BuildID: 20131204004003
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/244e98241b2c
Gaia: c8f14ad3950d59ba13d7639eff02d080060bb3ce
Version: 26.0
RIL Version: 01.02.00.019.102
Firmware Version: V1.2_20131115

1.3 Environmental Variables
Device: Buri v1.3 Mozilla RIL
Build ID: 20131203040236
Gecko: http://hg.mozilla.org/mozilla-central/rev/8648aa476eef
Gaia: 31808a29cfcffa584b6a88b4f1e515387f485a1b
Platform Version: 28.0a1
Firmware Version: v1.2_20131115