Closed Bug 940174 Opened 7 years ago Closed 7 years ago

"Bookmarks Toolbar Items" centers its contents when placed in the tabstrip

Categories

(Firefox :: Toolbars and Customization, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 31

People

(Reporter: Dolske, Assigned: jaws)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:P4])

Attachments

(3 files)

Attached image Screenshot
When the "Bookmarks Toolbar Items" widget -- the special widget that's replaces with actual bookmarks -- is in the bookmark toolbar (its default position), items appear left-aligned in the toolbar.

When the widget is dragged into the navbar, it correctly takes up minimal space.

But when it's placed in the tabstrip, it seems to take up an unusual amount of horizontal space, and the actual bookmarks end up centered within it.

Attached is a screenshot, showing this item (ie the 3 folders "Misc/Mozilla/scripts"), with adblock to the left and RSS to the right as indicative markers.
Attached image In customization mode
Summary: "Bookmarks Toolbar Items" centers its contents → "Bookmarks Toolbar Items" centers its contents when placed in the tabstrip
Whiteboard: [Australis:P4]
Attached patch PatchSplinter Review
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8412336 - Flags: review?(mdeboer)
Comment on attachment 8412336 [details] [diff] [review]
Patch

Review of attachment 8412336 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! Thanks!
Attachment #8412336 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/integration/fx-team/rev/49ec0d4753dd
Keywords: checkin-needed
Whiteboard: [Australis:P4] → [Australis:P4][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/49ec0d4753dd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P4][fixed-in-fx-team] → [Australis:P4]
Target Milestone: --- → Firefox 31
Flags: in-testsuite?
Depends on: 1043257
You need to log in before you can comment on or make changes to this bug.