Build dom/base in unified mode

RESOLVED FIXED in mozilla28

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

Trunk
mozilla28
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 4 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 8334327 [details] [diff] [review]
Build dom/base in unified mode
Attachment #8334327 - Flags: review?(ehsan)
(Assignee)

Comment 2

5 years ago
Created attachment 8334329 [details] [diff] [review]
Build dom/base in unified mode
Attachment #8334327 - Attachment is obsolete: true
Attachment #8334327 - Flags: review?(ehsan)
Attachment #8334329 - Flags: review?(ehsan)
(Assignee)

Comment 3

5 years ago
Created attachment 8334335 [details] [diff] [review]
Build dom/base in unified mode

Now verified to build on 3 platforms...
Attachment #8334329 - Attachment is obsolete: true
Attachment #8334329 - Flags: review?(ehsan)
Attachment #8334335 - Flags: review?(ehsan)
(Assignee)

Comment 4

5 years ago
Comment on attachment 8334335 [details] [diff] [review]
Build dom/base in unified mode

Still getting linking errors, in fact.
Attachment #8334335 - Flags: review?(ehsan)
(Assignee)

Comment 5

5 years ago
Wooah!

My linking errors were about multiply defined symbols from ipc/glue/MessageChannel.cpp.

That made no sense from here, as I'm only tweaking dom/base here.

But there is a dom/base/MessageChannel.cpp file.

And the UNIFIED_SOURCES build system was mistaking ipc/glue/MessageChannel.cpp for dom/base/MessageChannel.cpp.
(Assignee)

Comment 6

5 years ago
Filed bug 940205.
(Assignee)

Comment 7

5 years ago
Created attachment 8334346 [details] [diff] [review]
Build dom/base in unified mode

Without MessageChannel.cpp, all is fine...
Attachment #8334335 - Attachment is obsolete: true
Attachment #8334346 - Flags: review?(ehsan)

Updated

5 years ago
Assignee: nobody → bjacob

Comment 8

5 years ago
Let's wait for bug 939580 and get MessageChannel.cpp in as well.
Depends on: 939580

Comment 9

5 years ago
Comment on attachment 8334346 [details] [diff] [review]
Build dom/base in unified mode

Review of attachment 8334346 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/DOMError.cpp
@@ +6,5 @@
>  
>  #include "mozilla/dom/DOMError.h"
>  #include "mozilla/dom/DOMErrorBinding.h"
>  #include "nsPIDOMWindow.h"
> +#include "DOMException.h"

You want mozilla/dom/DOMException.h.

::: dom/base/moz.build
@@ +102,5 @@
>  ]
>  
> +SOURCES += [
> +    'MessageChannel.cpp',
> +]

See my comment.

::: dom/base/nsQueryContentEventResult.h
@@ +3,5 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> +#ifndef mozilla_dom_nsQueryContentEventResult_h__
> +#define mozilla_dom_nsQueryContentEventResult_h__

No trailing underscores please.
Attachment #8334346 - Flags: review?(ehsan) → review-

Comment 10

5 years ago
I just landed bug 939580 on inbound.
Created attachment 8334778 [details] [diff] [review]
Build dom/base in unified mode
Attachment #8334346 - Attachment is obsolete: true
Attachment #8334778 - Flags: review?(ehsan)

Comment 13

5 years ago
Comment on attachment 8334778 [details] [diff] [review]
Build dom/base in unified mode

Review of attachment 8334778 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/moz.build
@@ +103,5 @@
>  
> +# these files couldn't be in UNIFIED_SOURCES for now for reasons given below:
> +SOURCES += [
> +    # MessageChannel.cpp collides with a like-named file in ipc/glue, until bug 939580 is fixed
> +    #'MessageChannel.cpp',

Please remove this stale comment.
Attachment #8334778 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/d8cd50781edc
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.