Closed
Bug 940204
Opened 11 years ago
Closed 10 years ago
Use FINAL_LIBRARY in comm-central
Categories
(MailNews Core :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 29.0
People
(Reporter: jcranmer, Assigned: jcranmer)
References
Details
Attachments
(1 file)
37.95 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
SQUEE!!!!!! This involves porting: e4b59fdbc9c2 Mike Hommey – Bug 939632 - Remove LIBRARY_NAME for leaf libraries. r=gps 7222bce61677 Mike Hommey – Bug 939632 - Allow LIBRARY_NAME to be omitted when FINAL_LIBRARY is defined. r=gps 71cbd5b14aec Mike Hommey – Bug 939074 - Remove most LIBXUL_LIBRARY. rs=gps 6d271ac31d9a Mike Hommey – Bug 939074 - Infer LIBXUL_LIBRARY from FINAL_LIBRARY. r=gps 5c94c8c9989e Mike Hommey – Bug 939622 - Remove LIBXUL_LIBRARY for intermediate libs that end up in gkmedias. r=gps 3ddc66e67343 Mike Hommey – Bug 939071 - Kill SHORT_LIBNAME. r=ted e50ec1860930 Mike Hommey – Bug 939042 - Remove library building related variables in directories that build no C/C++ sources. r=mshal 7fac57f507f2 Mike Hommey – Bug 939039 - Remove now useless FORCE_STATIC_LIB definitions. r=gps a02c4f6de455 Mike Hommey – Bug 939039 - Make FINAL_LIBRARY imply FORCE_STATIC_LIB. r=gps 8a50d16b1645 Mike Hommey – Bug 935881 - Remove SHARED_LIBRARY_LIBS handling for moz.build. r=gps 7161a2d28363 Mike Hommey – Bug 935881 - Use FINAL_LIBRARY for all (fake) libraries that end up linked in a single other library. r=gps a296036e608f Mike Hommey – Bug 935881 - Add a FINAL_LIBRARY variable to use in moz.build. r=gps And, oh boy, does it ever simplify our build system!
Assignee | ||
Comment 1•11 years ago
|
||
I've folded in simplification from bug 938437 into this patch and maybe one or two things more. I just couldn't help myself with the awesomeness that FINAL_LIBRARY brings :-)
Attachment #8336965 -
Flags: review?(mbanner)
Comment 2•10 years ago
|
||
Comment on attachment 8336965 [details] [diff] [review] Use it in comm-central Review of attachment 8336965 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, r=Standard8 assuming this has a green run on try.
Attachment #8336965 -
Flags: review?(mbanner) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/1f890b59ac38 (In reply to Joshua Cranmer [:jcranmer] from comment #1) > I've folded in simplification from bug 938437 into this patch and maybe one > or two things more. I just couldn't help myself with the awesomeness that > FINAL_LIBRARY brings :-) Since bug 938437 was backed out in the intervening period, I stripped those parts to make it pass try. But otherwise, it landed! \o/
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
You need to log in
before you can comment on or make changes to this bug.
Description
•