Closed Bug 940215 Opened 6 years ago Closed 6 years ago

Build netwerk/cache2, ftp, and rtsp in unified mode

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

To build these directories in unified mode, I:

* Renamed nsFtpConnectionThread.cpp's NowInSeconds() to (the admittedly ambiguous name) GetFtpTime() to avoid a NowInSeconds() conflict with nsHttp.h. I renamed the function instead of using nsHttp.h's function because I didn't want netwerk/protocol/ftp to rely on the netwerk/protocol/http's header files.

* Fixed -Wsometimes-uninitialized warning in nsFtpControlConnection.cpp.

* Only compiled Mozilla's RTSP code in unified mode to avoid making changing to the third-party RTSP code we imported from Android.

Green Try build:
https://tbpl.mozilla.org/?tree=Try&rev=c89cc9b72444
Attachment #8334355 - Flags: review?(mcmanus)
Attachment #8334355 - Flags: review?(mcmanus) → review+
https://hg.mozilla.org/mozilla-central/rev/b79bbe912c56
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Turns out that we can't build rtsp in unified mode because it forces NSPR logging (detected by bug 941854.)

I backed out that part: https://hg.mozilla.org/integration/mozilla-inbound/rev/a9edd6f12058
Blocks: 941854
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.