940223 - [Australis] Bufferapp's extra addon button occupying the wrong spot on the toolbar

Status: RESOLVED INVALID

(Firefox :: Toolbars and Customization, defect)

Description

[Akshat Kedia [:aks]]

Attachment: bufferapp_toolbar.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20131118094134

Steps to reproduce:

1. Open firefox nightly 28.0a1.
2. Install the bufferapp firefox addon from bufferapp.com/extras‎.
 


Actual results:

The toolbar has 2 bufferapp buttons, one of which is also at the wrong spot.


Expected results:

There should be only one addon button and at the right place.

Comment 1

[Matthew N. [:MattN]]

Thanks for the report.

I guess we'll need to figure out what they're doing to see if it needs to be fixed on our side or theirs.

Comment 2

[:Gijs (he/him)]

(In reply to Matthew N. [:MattN] (catching up on reviews) from comment #1)
> Thanks for the report.
> 
> I guess we'll need to figure out what they're doing to see if it needs to be
> fixed on our side or theirs.

I've seen this before in other add-ons when investigating the top 100 add-ons. It's an add-on problem where they insertItem something in either the nav-bar or the addon-bar (which means it ends up in the customize target of the navbar) and then check if it's where they expect, and if not they appendChild it to the nav-bar again, IIRC. It needs to be fixed within the add-on. We definitely don't duplicate buttons. I'm going to mark this as INVALID.