Closed Bug 940292 Opened 6 years ago Closed 6 years ago
Australis: Chevron of Bookmarks Toolbar is broken
Build Identifier: http://hg.mozilla.org/mozilla-central/rev/f2adb62d07eb Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131118094134 Steps To Reproduce: 1. Make sure Bookmarks Toolbar is overflowed 2. Enter customize mode 3. Move some toolbar item and Exit Customize mode 4. Click Chevron Actual Results: Chevron is broken. Expected Results: Chevron bookmark menu should pop up
It seems that exiting customization mode, the scrollbox for PlacesToolbarItems isn't firing/catching the overflow events, and as such you can see in the screenshot that the overflowed item is just being clipped.
(In reply to Jared Wein [:jaws] from comment #2) > It seems that exiting customization mode, the scrollbox for > PlacesToolbarItems isn't firing/catching the overflow events, and as such > you can see in the screenshot that the overflowed item is just being clipped. This is on the money. We destroy the places view when entering customize mode, and then create a new one. But the new one doesn't seem to get an overflow/underflow event at that point, probably because it's created too late. It should check for that state in the places toolbar helper's customizeDone function. I'll try and come up with a patch.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Reworked the code a bit so it was more reusable, and this works like a charm, as far as I can tell. Might fix some of our other issues, too...
Attachment #8343299 - Flags: review?(jaws)
Attachment #8343299 - Flags: review?(jaws) → review+
Whiteboard: [Australis:P1] → [Australis:P1][fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P1][fixed-in-fx-team] → [Australis:P1]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.