[Download Manager] Implement the flow when the user opens a file and this action fails from download list

RESOLVED FIXED in 1.3 Sprint 6 - 12/6

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: crdlc, Assigned: arcturus)

Tracking

(Blocks: 1 bug)

unspecified
1.3 Sprint 6 - 12/6
All
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Basically this bug should base its implementation on shared components
(Reporter)

Updated

4 years ago
Blocks: 926955
Depends on: 940291, 935082
Whiteboard: [systemsfe]
(Reporter)

Updated

4 years ago
Depends on: 945678
Depends on: 935088
Created attachment 8343718 [details] [review]
Pointer to PR 14459
Attachment #8343718 - Flags: review?(borja.bugzilla)
Assignee: nobody → francisco.jordano
Comment on attachment 8343718 [details] [review]
Pointer to PR 14459

Hi Gregor,

adding you as reviewer, since this is system frontend work, the download list, but we cannot find a peer in our timezone.

This will be already reviewed by Borja, who has been involved in the download manager track.

Cheers,
F.
Attachment #8343718 - Flags: review?(anygregor)
Attachment #8343718 - Flags: review?(aus)
I forgot to mention, we cannot find a 'settings' peer :)
Attachment #8343718 - Flags: review?(anygregor) → review?(21)
Comment on attachment 8343718 [details] [review]
Pointer to PR 14459

r+ but there is a few nits. I didn't reviewed the tests, I let that to the other reviewers :)
Attachment #8343718 - Flags: review?(21) → review+
Comments addressed :)

Thanks!
Flags: needinfo?(borja.bugzilla)
Comment on attachment 8343718 [details] [review]
Pointer to PR 14459

R+! Thanks for your patch!
Attachment #8343718 - Flags: review?(borja.bugzilla) → review+
Blocks: 935100

Comment 7

4 years ago
Comment on attachment 8343718 [details] [review]
Pointer to PR 14459

Looks fine to me. I don't have anything extra to add that hasn't already been pointed out by other reviewers.
Attachment #8343718 - Flags: review?(aus) → review+
Landed:

https://github.com/mozilla-b2g/gaia/commit/6865061768d4c78f391dee4ff04d825f8d829843

Thanks folks!
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Flags: needinfo?(borja.bugzilla)
Target Milestone: --- → 1.3 Sprint 6 - 12/6
You need to log in before you can comment on or make changes to this bug.