940298 - [Download Manager] Implement the flow when the user opens a file and this action fails from download list

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Cristian Rodriguez (:crdlc)]

Basically this bug should base its implementation on shared components

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 14459

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8343718 [details] [review]
Pointer to PR 14459

Hi Gregor,

adding you as reviewer, since this is system frontend work, the download list, but we cannot find a peer in our timezone.

This will be already reviewed by Borja, who has been involved in the download manager track.

Cheers,
F.

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

I forgot to mention, we cannot find a 'settings' peer :)

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8343718 [details] [review]
Pointer to PR 14459

r+ but there is a few nits. I didn't reviewed the tests, I let that to the other reviewers :)

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comments addressed :)

Thanks!

Comment 6

[Borja Salguero [:borjasalguero]]

Comment on attachment 8343718 [details] [review]
Pointer to PR 14459

R+! Thanks for your patch!

Comment 7

[Aus Lacroix [:aus]]

Comment on attachment 8343718 [details] [review]
Pointer to PR 14459

Looks fine to me. I don't have anything extra to add that hasn't already been pointed out by other reviewers.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/6865061768d4c78f391dee4ff04d825f8d829843

Thanks folks!