Closed
Bug 940317
Opened 12 years ago
Closed 12 years ago
Move the varObjFix flag from ContextOptions to RuntimeOptions
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: ejpbruel, Assigned: ejpbruel)
References
Details
Attachments
(1 file)
|
8.08 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
No description provided.
| Assignee | ||
Comment 1•12 years ago
|
||
Try run for this patch:
https://tbpl.mozilla.org/?tree=Try&rev=881f76bea990
Attachment #8334695 -
Flags: review?
Comment 2•12 years ago
|
||
Comment on attachment 8334695 [details] [diff] [review]
patch
Review of attachment 8334695 [details] [diff] [review]:
-----------------------------------------------------------------
This is green. r=bholley with comments addressed.
::: js/src/jsapi-tests/tests.h
@@ +300,5 @@
> virtual JSContext * createContext() {
> JSContext *cx = JS_NewContext(rt, 8192);
> if (!cx)
> return nullptr;
> + JS::RuntimeOptionsRef(cx).setVarObjFix(true);
This should not be in createContext, but in createRuntime.
Attachment #8334695 -
Flags: review? → review+
Comment 3•12 years ago
|
||
Assignee: nobody → ejpbruel
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•