940420 - It's nearly impossible to close browser app tabs with edge gestures enabled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Etienne Segonzac (:etienne)]

Looks like the sendTouchEvent/sendMouseEvent API doesn't work well for in-procress apps.

Comment 1

[Etienne Segonzac (:etienne)]

Vivien do you have a patch I can try?

Comment 2

[Jason Smith [:jsmith]]

Is this critical enough to block the edge gestures feature? If so, please nominate for 1.3?

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Etienne Segonzac (:etienne) from comment #1)
> Vivien do you have a patch I can try?

I think https://bug802237.bugzilla.mozilla.org/attachment.cgi?id=672864 should help.

Comment 4

[Etienne Segonzac (:etienne)]

Attachment: Rebased version of Vivien's patch

Here's a rebased version of the patch, looks like it works very nicely!

Comment 5

[Etienne Segonzac (:etienne)]

Confirmed that the patch works!
I'll let you take it from here Vivien :)

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug940420

Smaug, let me now if you're not the correct reviewer for that.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: add a sendTouchEventToWindow method to nsIDOMWindowUtils.idl

Seems like I forgot to change the UUID of nsIDOMWindowUtils.idl in the attached patch. Sorry for the noise.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8341188 [details] [diff] [review]
add a sendTouchEventToWindow method to nsIDOMWindowUtils.idl


>+nsDOMWindowUtils::SendTouchEventToWindow(const nsAString& aType,
>+                                         uint32_t *aIdentifiers,
>+                                         int32_t *aXs,
>+                                         int32_t *aYs,
>+                                         uint32_t *aRxs,
>+                                         uint32_t *aRys,
>+                                         float *aRotationAngles,
>+                                         float *aForces,
>+                                         uint32_t aCount,
>+                                         int32_t aModifiers,
>+                                         bool aIgnoreRootScrollFrame,
>+                                         bool *aPreventDefault)
* goes with the type, not param name (old code may use wrong style).

>+NS_IMETHODIMP
>+nsDOMWindowUtils::SendTouchEventCommon(const nsAString& aType,
>+                                       uint32_t *aIdentifiers,
>+                                       int32_t *aXs,
>+                                       int32_t *aYs,
>+                                       uint32_t *aRxs,
>+                                       uint32_t *aRys,
>+                                       float *aRotationAngles,
>+                                       float *aForces,
>+                                       uint32_t aCount,
>+                                       int32_t aModifiers,
>+                                       bool aIgnoreRootScrollFrame,
>+                                       bool aToWindow,
>+                                       bool *aPreventDefault)
ditto

>   nsEventStatus status;
>+  if (aToWindow) {
>+    nsCOMPtr<nsIPresShell> presShell = presContext->PresShell();
>+    if (!presShell)
>+      return NS_ERROR_FAILURE;
{} with if. Same also elsewhere.

>+  NS_IMETHOD SendTouchEventCommon(const nsAString& aType,
>+                                  uint32_t *aIdentifiers,
>+                                  int32_t *aXs,
>+                                  int32_t *aYs,
>+                                  uint32_t *aRxs,
>+                                  uint32_t *aRys,
>+                                  float *aRotationAngles,
>+                                  float *aForces,
>+                                  uint32_t aCount,
>+                                  int32_t aModifiers,
>+                                  bool aIgnoreRootScrollFrame,
>+                                  bool aToWindow,
>+                                  bool *aPreventDefault);
* goes with the type


Yeah, I think this makes sense, r=me
We have similar method for mouseevents.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4771c427c785

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4771c427c785