In a repo far, far away... we used data-butter-exclude to prevent certain html tags from being exported in the final embed. We've since moved to a proper templating system, so we can remove instances of data-butter-exclude now.
Created attachment 8334589 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/330
Attachment #8334589 - Flags: review?(scott)
Comment on attachment 8334589 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/330 Everything works fine. I wonder though, can we nuke data-butter-exclude from the tests too?
Attachment #8334589 - Flags: review?(scott) → review-
Comment on attachment 8334589 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/330 I've removed the other instances of "data-butter-exclude" too
Attachment #8334589 - Flags: review- → review?(scott)
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org https://github.com/mozilla/popcorn.webmaker.org/commit/0b019d7aed06763d9b96003a045536dd46ae1481 Fix bug 940442 - Remove data-butter-exclude
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.