Closed
Bug 940442
Opened 11 years ago
Closed 11 years ago
Exclude data-butter-exclude
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Webmaker Graveyard
Popcorn Maker
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jon, Assigned: jon)
Details
Attachments
(1 file)
In a repo far, far away... we used data-butter-exclude to prevent certain html tags from being exported in the final embed. We've since moved to a proper templating system, so we can remove instances of data-butter-exclude now.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8334589 -
Flags: review?(scott)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8334589 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/330 Everything works fine. I wonder though, can we nuke data-butter-exclude from the tests too?
Attachment #8334589 -
Flags: review?(scott) → review-
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8334589 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/330 I've removed the other instances of "data-butter-exclude" too
Attachment #8334589 -
Flags: review- → review?(scott)
|
|
||
Updated•11 years ago
|
Attachment #8334589 -
Flags: review?(scott) → review+
|
||
Comment 4•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org https://github.com/mozilla/popcorn.webmaker.org/commit/0b019d7aed06763d9b96003a045536dd46ae1481 Fix bug 940442 - Remove data-butter-exclude
|
|
||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•