Exclude data-butter-exclude

RESOLVED FIXED

Status

Webmaker
Popcorn Maker
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: jbuck, Assigned: jbuck)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
In a repo far, far away... we used data-butter-exclude to prevent certain html tags from being exported in the final embed. We've since moved to a proper templating system, so we can remove instances of data-butter-exclude now.
Comment on attachment 8334589 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/330

Everything works fine.

I wonder though, can we nuke data-butter-exclude from the tests too?
Attachment #8334589 - Flags: review?(scott) → review-
(Assignee)

Comment 3

4 years ago
Comment on attachment 8334589 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/330

I've removed the other instances of "data-butter-exclude" too
Attachment #8334589 - Flags: review- → review?(scott)
Attachment #8334589 - Flags: review?(scott) → review+

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.