Closed
Bug 940444
Opened 12 years ago
Closed 12 years ago
youtube wrapper does not properly destroy itself when you try to change the source
Categories
(Webmaker Graveyard :: popcorn.js, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: thecount, Assigned: thecount)
Details
Attachments
(1 file)
If you change the source twice after a youtube clip is loaded, it throws an error.
The error is because the elem we used to setup youtube with has been removed from the dom from youtube, so when we do our cleanup and remove it from the previous parent it crashes.
We should not be assming it still has the same parent.
On top of that, if we call player.destroy() using YouTube we don't even have to deal with it.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → scott
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8335334 -
Flags: review?(schranz.m)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8335334 [details] [review]
https://github.com/mozilla/popcorn-js/pull/358
I actually can't reproduce this on master. Perhaps I'm missing something from your steps?
Attachment #8335334 -
Flags: review?(schranz.m) → review-
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 8335334 [details] [review]
https://github.com/mozilla/popcorn-js/pull/358
Updates.
And regarding strs. Try running the test without the patch, should fail.
Attachment #8335334 -
Flags: review- → review?(schranz.m)
|
|
||
Updated•12 years ago
|
Attachment #8335334 -
Flags: review?(schranz.m) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Staged: https://github.com/mozilla/popcorn-js/commit/b5f8f42505488861303bc678230ce7f6195fc1b8
Needs verification.
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
|
|
Assignee | |
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
Flags: needinfo?(scott)
You need to log in
before you can comment on or make changes to this bug.
Description
•