Closed Bug 940451 Opened 6 years ago Closed 6 years ago
Tab key should navigate through urlbar autocomplete tiles
To match desktop Firefox behavior, pressing "tab" while typing in the urlbar should select the next autocomplete tile (same as pressing "down"), while "shift-tab" should select the previous tile (same as pressing "up"). The autocomplete widget has code for this built-in; we just need to enable it by adding the "tabscrolling" attribute. We also need our autocomplete popup to expose the "mPopupOpen" property that the toolkit code uses. (Arguably the latter is a bug in toolkit; I'll file a follow-up bug to fix it.)
After writing this patch I got an intermittent failure in this test. I'm not sure if this was an existing failure or was caused/exposed by my changes, but either way this fixes it.
Attachment #8334595 - Flags: review?(rsilveira)
Oops, uploaded the wrong file. Here's the real patch.
Attachment #8334595 - Flags: review?(rsilveira) → review+
Attachment #8334596 - Flags: review?(rsilveira) → review+
https://tbpl.mozilla.org/?tree=Try&rev=c12416c6dd70 https://hg.mozilla.org/integration/fx-team/rev/0e97ac525967 https://hg.mozilla.org/integration/fx-team/rev/4d9671759976
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.