Closed
Bug 940555
Opened 11 years ago
Closed 10 years ago
Port press speaker request page to bedrock
Categories
(www.mozilla.org :: Bedrock, defect)
www.mozilla.org
Bedrock
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: sgarrity, Assigned: sgarrity)
References
()
Details
(Whiteboard: [kb=1187503] )
Attachments
(1 file)
93.88 KB,
patch
|
pmac
:
review+
|
Details | Diff | Splinter Review |
The speaker request form at http://www.mozilla.org/en-US/press/speakerrequest/ needs to be ported to Bedrock. Much like the Fraud Report page (http://www.mozilla.org/en-US/legal/fraud-report/) ported in Bug 905802, this page includes a captcha and file-upload function. We should probably update the destination email address for Bug 759431 while we're at it.
Assignee | ||
Updated•11 years ago
|
Whiteboard: [kb=1187503]
Assignee | ||
Comment 1•11 years ago
|
||
jpetto, I CC'ed you on this in case any of your recent work on the Fraud Report page might be reusable for this.
Updated•10 years ago
|
Assignee: nobody → jon
Comment 2•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/3fbc47ff4fdce5dac4b84d8596ed8a767419050c Port /press/speakerrequest/ to bedrock. Bug 940555. https://github.com/mozilla/bedrock/commit/ec4bd192a19e9f00befc988240cab9ef4f81da0b Merge pull request #1639 from jpetto/bug-940555-port-speaker-request-to-bedrock Port /press/speakerrequest/ to bedrock. Bug 940555.
Comment 3•10 years ago
|
||
verified fixed https://www.allizom.org/en-US/press/speakerrequest/
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 4•10 years ago
|
||
verified fixed http://www.mozilla.org/en-US/press/speakerrequest/
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 5•10 years ago
|
||
This patch removes all of the speaker request pages from SVN now that the page has been ported to Bedrock. A few other orphaned press CSS/img files have been removed too - I searched to make sure any removed files where not referenced anywhere.
Assignee: jon → steven
Attachment #8382182 -
Flags: review?(pmac)
Assignee | ||
Comment 6•10 years ago
|
||
Reopening until we get the SVN files removed.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Comment 7•10 years ago
|
||
Comment on attachment 8382182 [details] [diff] [review] Patch to remove Speaker Request files from SVN Review of attachment 8382182 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. I did see that js/mobile/beta/gomobile.js references a Recaptcha object in the JS. Not sure from whence this comes, but I'd imagine it has something to do with the recaptcha library. Perhaps that file is also unused, or I could be wrong? r+ as long as that file is cool.
Attachment #8382182 -
Flags: review?(pmac) → review+
Assignee | ||
Comment 8•10 years ago
|
||
(In reply to Paul McLanahan [:pmac] from comment #7) > Looks good. I did see that js/mobile/beta/gomobile.js references a Recaptcha > object in the JS. Not sure from whence this comes, but I'd imagine it has > something to do with the recaptcha library. Perhaps that file is also > unused, or I could be wrong? Good eye, sir. I looked into it and this file was used by a page that used to live at /mobile/beta/gomobile/ but the page no longer exists. We should be fine.
Assignee | ||
Comment 9•10 years ago
|
||
Applied in trunk in r125279, tags/stage in r125280, and tags/production in r125281.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•