940574 - [B2G][Settings][SIM Security] When SIM Pin is disabled the "Change PIN" button is visible and selectable

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot

Description:
After user disables SIM PIN on SIM Security page in settings, the "Change PIN" button is still visible and selectable. Although user is able to interact with button, it's functionality appears disabled.

Repro Steps:
1) Updated Buri to Build ID: 20131119004006
2) Select Settings
3) Press SIM Security under Privacy and Security
4) Disable SIM PIN
5) Observe "Change PIN" button is visible and selectable

Actual:
"Change PIN" button is visible and selectable after SIM PIN is disabled.

Expected:
"Change PIN" button does not appear when SIM PIN is disabled.

Environmental Variables
Device: Buri v 1.2 COM RIL
Build ID: 20131119004006
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/fe2a7f0db27b
Gaia: 9439907a255e04de4c33493fe03d6670c8256e2f
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: V1.2_US_20131115

Notes:
Repro frequency: 3/3, 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/2932/
See attached: screenshot

Comment 1

[Brogan Zumwalt [Inactive]]

Issue does not reproduce on 1.1

Result: "Change PIN" button does not appear when SIM PIN is disabled.

Environmental Variables
Device: Leo v 1.1.0 COM RIL
Build ID: 20131111041200
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/31fa87bfba88
Gaia: d9c6b0c3384625e467f892c9dafbc40cfe132180
Platform Version: 18.1
RIL Version: 01.01.00.019.281 
Firmware Version: lge_default

Comment 2

[Brogan Zumwalt [Inactive]]

Attachment: LogCat

Comment 3

[Jason Smith [:jsmith]]

This is disappointing, but we probably can't block on this at this point in the release.

Comment 4

[Jason Smith [:jsmith]]

I'm pretty sure this was caused by bug 916059.

Comment 5

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Hi all,

I cannot reproduce it on latest master branch of gaia.

Gaia:     298e6c5af4fe0cc0c4cfd88f7973bdd08e33aa51
Gecko:    http://hg.mozilla.org/mozilla-central/rev/597287004ff5
BuildID   20131120062258
Version   28.0a1

I think the patch of bug 940162 already took care of the problem.

Comment 6

[Jason Smith [:jsmith]]

Right - I'll put qawanted to confirm this by testing this on master.

Comment 7

[Nikolai Khristoforov]

This bug did not reproduce on the latest Buri 1.3 build. The Change PIN option and toggle were not availabe after disabling SIM PIN.

Device: Buri v1.3 Moz RIL
BuildID: 20131121040202
Gaia: 71063dd91bc8cbb15ba335236ed67a1c5058bd58
Gecko: cf378dddfac8
Version: 28.0a1