940654 - [B2G][Settings][SIM Security] User can exit without entering PIN after toggling SIM PIN and keep changed settings

Status: RESOLVED DUPLICATE of bug 940162

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Video Clip

Description:
When user is prompted to enter SIM PIN after toggling SIM PIN security, user can press back button to bypass entering PIN. This results in multiple issues including the SIM Security status showing as disabled in the Settings app even if it is enabled. After backing out of the SIM PIN input screen after initial toggle, entering the correct PIN after a second toggle results in a message indicating an incorrect PIN has been entered. While user remains on this screen re-entering the correct or incorrect PIN any number of times results in the same issue, but the number of tries remaining does not decrease from 3. Backing out of this screen then re-toggling allows apparent functionality to return to PIN screen allowing user to input correct PIN, but status shown in Settings app remains incorrect and the SIM PIN functionality is disabled despite setting shown on SIM Security screen.

Repro Steps:
1) Updated Buri to Build ID: 20131119004006
2) Open Settings app with SIM card installed
3) Open SIM Security screen under Privacy & Security
4) Toggle SIM PIN setting
5) On Enter SIM PIN screen press back button

Actual:
User can exit without entering PIN after toggling SIM PIN and keep changed settings.

Expected:
Backing out of Enter SIM PIN screen does not retain settings changed.

Environmental Variables
Device: Buri v 1.2 COM RIL
Build ID: 20131119004006
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/fe2a7f0db27b
Gaia: 9439907a255e04de4c33493fe03d6670c8256e2f
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: V1.2_US_20131115

Notes:
Repro frequency: 3/3, 100
Link to failed test case: https://moztrap.mozilla.org/manage/case/2932/
See attached: video clip

Comment 1

[Brogan Zumwalt [Inactive]]

Issue does not reproduce on 1.1

Result: Backing out of Enter SIM PIN screen does not retain settings changed.

Environmental Variables
Device: Leo v 1.1.0 COM RIL
Build ID: 20131111041200
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/31fa87bfba88
Gaia: d9c6b0c3384625e467f892c9dafbc40cfe132180
Platform Version: 18.1
RIL Version: 01.01.00.019.281 
Firmware Version: lge_default

Comment 2

[Brogan Zumwalt [Inactive]]

Attachment: LogCat

Comment 3

[Jason Smith [:jsmith]]

This sounds bad - sounds like SIM Pin security can be bypassed.

Comment 4

[Jason Smith [:jsmith]]

This is probably a fallout from bug 916059.

Comment 5

[Preeti Raghunath(:Preeti)]

Requesting back out of 916059

Comment 6

[Jason Smith [:jsmith]]

Blocking on this based on it's impact, but we should discuss whether we should consider backing out bug 916059.

Comment 7

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Hi all,

I cannot reproduce it on latest master branch of gaia.

Gaia:     298e6c5af4fe0cc0c4cfd88f7973bdd08e33aa51
Gecko:    http://hg.mozilla.org/mozilla-central/rev/597287004ff5
BuildID   20131120062258
Version   28.0a1

I think the patch of bug 940162 already took care of the problem.

Comment 8

[Jason Smith [:jsmith]]

QA Wanted to confirm - check & see if this reproduces on master

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

after bug 940162 is uplifted to 1.2, lets confirm if this bug still happens

Comment 10

[Fabien Cazenave [:kaze]]

Sorry for the late pong (too much snow for my internet connection, apparently).

Yes, bug 940162 fixes this, see bug 916059 comment 15.