940697 - Tasks have some menu items and controls wrongly enabled when the calendar is read-only.

Status: RESOLVED FIXED

(Calendar :: Tasks, defect)

Description

[Decathlon]

Steps to reproduce:
Create a new task and then set the related calendar in read-only status, then take a look at the following elements:

-  menu item "Mark Completed" in the context menu (task view and today-pane);
-  button "Mark Completed" in the task-action toolbar (task view);
-  checkbox "Done" in the task list (task view and today-pane);
these elements are enabled (or get enabled when the context menu appears). Clicking on them causes an error message "An error occurred when writing to the calendar ....!" and the yellow triangle appears beside the calendar in the calendar list.

-  "Cut" menu item in the context menu;
-  "Delete task" menu item in the context menu;
are enabled but they don't cause any problem when clicked.

Hovering with the mouse pointer over any menu item with a submenu (Progress, Priority, ...) causes the correct disabled status of the "Mark Completed" and "Cut" menu items in the context menu.

Comment 1

[Decathlon]

Attachment: Patch - v1

Not completely clear why, but it seems that some commands need to be updated before showing the context menu.

I've also changed the behavior of the menu items "Progress" "Priority" and "Postpone Task" in order to make them consistent with the same items in the main menu that are disabled at the first level instead of being enabled and showing a submenu with all disabled options.

The patch disables the action on the "Done" checkboxes in the tasks list, but doesn't disable the checkboxes because I'm having problems in doing it correctly in all the cases. If you agree I will try in another patch or another bug.

Comment 2

[Matthew Mecca [:mmecca]]

(In reply to Decathlon from comment #1)
> The patch disables the action on the "Done" checkboxes in the tasks list,
> but doesn't disable the checkboxes because I'm having problems in doing it
> correctly in all the cases. If you agree I will try in another patch or
> another bug.

I'd suggest adding "readonly" as a return value for getProgressAtom here:
http://mxr.mozilla.org/comm-central/source/calendar/base/src/calUtils.js#1137

then use the "disabled" checkbox image in the css rule like here:
http://mxr.mozilla.org/comm-central/source/calendar/base/themes/windows/calendar-task-tree.css#21

I think that's fine for a separate bug.

Comment 3

[Matthew Mecca [:mmecca]]

Comment on attachment 8339209 [details] [diff] [review]
Patch - v1

Looks good. r=mmecca

Comment 4

[Decathlon]

(In reply to Matthew Mecca [:mmecca] from comment #2)
> 
> I'd suggest adding "readonly" as a return value for getProgressAtom here:
> ...

The problem is about the way to control it properly. I will ask you something more specific ;)

Comment 5

[Decathlon]

Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/2c9924d0479d


Since the bug causes a message error displayed directly to the user, I'm asking if it worths to apply the patch on comm-aurora and/or comm-beta.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8339209 [details] [diff] [review]
Patch - v1

I'm fine with aurora/beta :) a=philipp

Comment 7

[Decathlon]

Pushed to comm-beta 
http://hg.mozilla.org/releases/comm-beta/rev/9bcdf8272b72

The patch has been automatically applied in comm-aurora with the new branches.