Closed Bug 940713 Opened 6 years ago Closed 6 years ago

Enable autoclose brackets for source editor

Categories

(DevTools :: Source Editor, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 28

People

(Reporter: gl, Assigned: gl)

References

Details

Attachments

(1 file)

Codemirror provides an option to autoclose brackets. This would be useful for the scratchpad and style editor.
Attached patch 940713.patchSplinter Review
WIP patch. I think the feature should be disabled in the inspector.
After discussing with Anton, disregard disabling for the inspector (editing outer html). This would be useful for inline javascript.
Assigning to Gabriel.
Assignee: nobody → gabriel.luong
Currently, looking into unit tests for this add-on.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P2
Probably won't get to the unit tests till next week. I am curious if we could add in the unit tests later since this is a CM add-on (closebrackets.js).
Flags: needinfo?(anton)
Actually, StyleEditor already uses this addon. So the question is whether we should enable it by default or not. I don't think there's any harm in enabling it by default—given that all current tests pass.
Flags: needinfo?(anton)
Attachment #8334895 - Flags: review?(anton)
Attachment #8334895 - Flags: review?(anton) → review+
https://hg.mozilla.org/mozilla-central/rev/e37495564ada
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Keywords: verifyme
Blocks: 963937
Verified as fixed on latest Aurora 28.0a2 (buildID: 20140131004003) under MAC OSX 10.8.5 32-bit, Ubuntu 32-bit and Win 7 64-bit.

The brackets are autoclosed on Inspector, Scratchpad and Style Editor.
Status: RESOLVED → VERIFIED
Keywords: verifyme
QA Contact: petruta.rasa
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.