940728 - Quicklinks: Identation of main <li> items

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Design, defect, P2)

Description

[Florian Scholz (Open Web Docs)]

Attachment: quicklinks-as-wanted.png

Just a minor thing I like to see fixed to drive the quicklinks to perfection :)

Look at the quicklinks at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/test

On the very top, you have the main list item "RegExp" and more on the bottom under "Inheritance" you find "Function" and "Object". These three links shouldn't be indented by padding-left: 20px, so that "Methods" and "Properties" look more like sub items. 

(The free space of 20px is probably for the icons or the arrows, but these top-level list items don't have any).

See the attached screenshot of how I would like to see it.

Not blocking I think, but it would make me happy :)

Comment 1

[ali spivak]

Agreed, not a blocker. Do need to fix this, and it could be a good mentoring bug...

Comment 2

[Jonathan Sundqvist]

I could fix this if it gets assigned to me :)

Comment 3

[Māris Fogels [:mars] (please needinfo)]

David, do you have some time to be a mentor for this bug?

Comment 4

[David Walsh :davidwalsh]

I do, but have we committed to doing this?  This was never spec'd so I take exception to asking for it to be "fixed".  If we do want to do it, however, I'm happy to help mentor Jonathan, 100% :)

Comment 5

[Māris Fogels [:mars] (please needinfo)]

Awesome David, thanks!  Jonathan, it's all yours :)  :fsholz and :davidwalsh on IRC can give you a hand.  I've assigned the bug to you, but please feel free to unassign it if you don't have time to pick this up.

Comment 6

[Jonathan Sundqvist]

Hi, 
I took a look at it and I solved it in the page inspector. However I can't seem to find the redesign-wiki-min.css or the like in the kuma repository. What file should I change and then include in my pull-request?

Comment 7

[John Karahalis [:openjck]]

redesign-wiki-main.css is a compilation of everything included in main.styl

https://github.com/mozilla/kuma/blob/master/media/redesign/stylus/main.styl

Comment 8

[David Walsh :davidwalsh]

You'll actually want wiki.styl :)

To compile all the stylesheets, from the kuma directory, run:

`scripts/compile-stylesheets`

Comment 9

[John Karahalis [:openjck]]

Scratch that (I incorrectly read min as main). redesign-wiki-min.css was actually recently replaced by wiki-min.css, although that will not change on production for a day or two. The styles you are looking for will appear in one of these Stylus files.

media/css/wiki.css
media/css/wiki-screen.css
media/redesign/stylus/wiki.styl
media/redesign/stylus/zones.styl
media/redesign/stylus/diff.styl

Comment 10

[Jonathan Sundqvist]

Ok, here goes! https://github.com/mozilla/kuma/pull/2031 I believe that should do it.

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/3c4d38883b9c2f196cdc967645a19c3e8eba1853
Fix Bug 940728 - stylesheets

https://github.com/mozilla/kuma/commit/fcf3b73ecdec47389a261dbc73ba389a9d471f05
Bug 940728 - Added proposed CSS

https://github.com/mozilla/kuma/commit/350f6de16b7bc66c6f9f4d7d74cc97ff012f92a5
Merge pull request #2031 from jonathan-s/css-fix

Fix Bug 940728 - stylesheets