940750 - Replace FBC searchplugin with WolneLektury.pl

Status: RESOLVED FIXED

(Mozilla Localizations :: pl / Polish, defect)

Description

[Stefan Plewako [:stef]]

Attachment: aurora patch

After discussion in Aviary.pl bug 3715 (http://bugs.aviary.pl/show_bug.cgi?id=3715) we would like to remove FBC and add WolneLektury.pl searchplugin.

You can read about WolneLektury here https://wolnelektury.pl/info/o-projekcie/

The main reason for the change is that while both services offer similar content, WolneLektury provide it in a way more expected by typical user - eg html/epub/mobi formats vs scans of old books, better search results, more friendly website and so on.

Comment 1

[Francesco Lodolo [:flod] (OOO July 12–20)]

Hi Stefan, we need permission from the website owner to add a searchplugin to Firefox builds. I'm CCing Axel and Jeff to be sure that nothing has changed from the last time I had to do this for my own locale.

Can you guys get in touch with WolneLektury, let them know what you plan to do (briefly explain what a searchplugin is, that it will generate traffic, etc.) and ask them to send an email that authorizes Mozilla to use their website in this way? It would be great if this mail was in English, but Polish plus your translation in English would be fine as well.

If you prefer I can do this, but receiving an email in Polish would probably be better.

Comment 2

[Stefan Plewako [:stef]]

They reached us in http://bugs.aviary.pl/show_bug.cgi?id=3715 stating that they would like to be included in firefox pl releases (following rules described at http://www.aviary.pl/wspolpraca/twoja-witryna-w-firefoksie/) and additionally in comment 16 in the bug they explicitly approved usage of HTTPS.

Please let me know if such public statements are not enough and we need private authorization email (and who should be on the cc list).

Comment 3

[Francesco Lodolo [:flod] (OOO July 12–20)]

Talked with Pike and Stas on IRC about this, we shouldn't need more authorizations.

Copying over the original comment 0 on Aviary's Bugzilla

***********
Radek Czajka 2011-02-08 08:05:48 CET

Chciałbym zgłosić wyszukiwarkę na stronie http://www.wolnelektury.pl jako wtyczkę wyszukiwarki w polskiej instalacji Firefoksa.

1. Witryna zawiera kanon literatury z domeny publicznej w różnych formatach, więc jest przydatna uczniom, nauczycielom, studentom, i w ogóle każdemu, kto chce czytać (lub słuchać) literaturę po polsku.

2. Witryna jest w pełni funkcjonalna w Firefoksie, i ma wyszukiwarkę podpiętą jako widoczny w Firefoksie link opensearch.

3. Teksty w witrynie są tagowane semantycznie, opracowywane przez literaturoznawców, audiobooki nagrywane przez profesjonalnych aktorów, więc bez obawy można mówić o najwyższej jakości przygotowanych treści.

4. Witryna nie jest komercyjna, Wolne Lektury są projektem fundacji Nowoczesna Polska.
***********

Comment 4

[Francesco Lodolo [:flod] (OOO July 12–20)]

Comment on attachment 8334928 [details] [diff] [review]
aurora patch

Review of attachment 8334928 [details] [diff] [review]:
-----------------------------------------------------------------

Searchplugin is broken for me (search engines don't appear after adding it, looks like it's line 5 the problem).

Please remove line 5, fix and move up the image tag.

::: browser/searchplugins/wolnelektury-pl.xml
@@ +1,5 @@
> +<!-- This Source Code Form is subject to the terms of the Mozilla Public
> +   - License, v. 2.0. If a copy of the MPL was not distributed with this
> +   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
> +
> +<?xml version="1.0" encoding="UTF-8"?>

Declaration not needed.

@@ +13,5 @@
> +      type="application/x-suggestions+json" />
> + <Url method="GET"
> +      template="https://wolnelektury.pl/szukaj/?q={searchTerms}"
> +      type="text/html" />
> + <Image height="16" width="16" type="image/png">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEAAAABACAMAAACdt4HsAAAAMFBMVEUAAAA+Ym+buyu/ABnsvgCkfTDCvBk9Ym49YW62vB6/ABmbuyq/ABnsvgC/ABnsvgDWMO0CAAAAEHRSTlMA+/v8/B9QX613WriWlsnJSmC38gAAAvFJREFUeNqlVVGygzAIbK0kRo25/20fgeCawabtPD6cSt2FXSI+HmnaUnj8I7aJo5LQr0hKuSQjUJbwC3iuUaqEiULajCPRt2AjoGkKkgaJqkkb3aJLg+ZA85w5NU3J/j07IeS7CMXAcjfPQVzcrhVC5QhCoHlEEnQ+VbISSU9T95hBpz6fi9S+elSqBWqCm6xe6YKX4r0rYsGd2MCUeu2qdWVggZTyGuyKh91Mkub0JHgNfT6L3D6K5ehWg+Yh1346CzBIpwF5KHAWYJAjDeUshsggHWjQGoRizoJPGsxvh2fSjIJuDsk0OAXOgvuzRFcN5CzEizCwcTNiHAI3RITZ1akyGn8IQp4tiYLkbdTOcAiA5uiTCesMGdI+8pw9uiRnO9YqDoe4WE67KRdBZ074CLrOEl1bYAIyu9MIDQ5IqQ0xQRAFlB3aBXazSgm6X6nyCbwEOFEwBc/RpAiDYFK3z8h8HEhJmxwhCiS3dejkvgs01gKxxE9TN4UixEP4uq7UvTbEsnEChrHux0tiPTtA5EAfKu8vBKEFfNCG6Fb62Ln/lVuAIekL1UcDN7/4FphIY/BupVcyOvOAKjY+n8sS3xM0+E4nYfNQoM/4oOVZY6F3votsu1Mte22DSICxMi1C4bT4GaKZ/bVGRjNO+zKOj+ijNcMuRgZzF4YxKXGE3ukUdlQLqF5ayqQYpT8BcKIq2Ft1rqkpSOkZCOguyffy5HK2AClL1z3QXZKv8iS5lmNPyepvDgcrsOJWENFTytQtoIC0FNkVAVVQa4Gujkspb7tkoIAcgZJq995GzUPt4U9FI4UGbyNBwf5OATQMbMTm8LaMNQyGuCI31gAL/CGA3ws03MyBhgq0e68BlHcWrF1T0r3TAEpYgH2GuTgN3gRUw3t9AC/QdxoiXgR8VbwihUasRAwSFugHDfvME+h+tfWOPBeltfsuuCDGYJtpIzBBoeKbR3sukDCLmHB8CXZrVWnqzH8Bo5HG8vhHxLiwhD+tsR4JGIVW9AAAAABJRU5ErkJggg==</Image>

No point in adding a 64px icon. Please use a 16px icon, also move the image tag after InputEncoding

Comment 5

[Stefan Plewako [:stef]]

Attachment: patch v2

Comment 6

[Francesco Lodolo [:flod] (OOO July 12–20)]

Comment on attachment 8336026 [details] [diff] [review]
patch v2

Review of attachment 8336026 [details] [diff] [review]:
-----------------------------------------------------------------

Patch and search engine tested. Please land this with the right commit message (bug number, r=flod).

Comment 7

[Stefan Plewako [:stef]]

Landed,
http://hg.mozilla.org/releases/l10n/mozilla-beta/pl/rev/128075b1edd5
http://hg.mozilla.org/releases/l10n/mozilla-aurora/pl/rev/559d86c9f1ca

Thx!