Closed Bug 940806 Opened 12 years ago Closed 12 years ago

Gfx info is not being properly reported in Telemetry

Categories

(Toolkit :: Telemetry, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: vladan, Assigned: vladan)

Details

Attachments

(1 file)

We're not reporting any of the gfx system info fields whose value is boolean "false" because of a bad comparison in TelemetryPing.js > false != "" false > false !== "" true
Attachment #8335009 - Flags: review?(dteller)
Comment on attachment 8335009 [details] [diff] [review] Do a strict inequality comparison Review of attachment 8335009 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/telemetry/TelemetryPing.js @@ +373,5 @@ > if (gfxInfo) { > for each (let field in gfxfields) { > try { > let value = ""; > value = gfxInfo[field]; Could you take the opportunity to make this let value = gfxInfo(field); ? @@ +374,5 @@ > for each (let field in gfxfields) { > try { > let value = ""; > value = gfxInfo[field]; > + if (value !== "") { You'll need a comment to explain why you need a strict comparison here (i.e. it's not evident that we're comparing booleans with strings in some cases or that |"" == false|).
Attachment #8335009 - Flags: review?(dteller) → review+
Assignee: nobody → vdjeric
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: