940884 - B2G SMS: Create MobileMessageDB.jsm

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

+++ This bug was initially created as a clone of Bug #836542 +++

Move nearly all MobileMessageDatabaseService.js lines into a jsm so that we can have a test on it.

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Attachment: part 1/3: create MobileMessageDB.jsm

Simply copy MobileMessageDatabaseService.js as MobileMessageDB.jsm.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Attachment: part 2.a/3: Changes to adopt MobileMessageDB.jsm

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Attachment: part 2.b/3: Move init functions out of MobileMessage constructor

This patch is to ease test cases development, so that we can have full control to database initialization process.

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Attachment: part 3/3: test cases

test cases for MobileMessageDB init/close/re-init.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

These patches are based on those of bug 921918.

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

full try: https://tbpl.mozilla.org/?tree=Try&rev=34ce4204d66e

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

Mnw failed due to bug 940881, which had already fix landed.  Re-trigger again.
The new test case introduced in attachment 8336764 [details] [diff] [review] passed successfully.

Comment 8

[Gene Lian (I already quit Mozilla)]

Comment on attachment 8336762 [details] [diff] [review]
part 2.b/3: Move init functions out of MobileMessage constructor

Review of attachment 8336762 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/src/gonk/MobileMessageDB.jsm
@@ +290,5 @@
>  
>    /**
> +   * Initialize this MobileMessageDB.
> +   *
> +   * @param aName

s/aName/aDbName

@@ +292,5 @@
> +   * Initialize this MobileMessageDB.
> +   *
> +   * @param aName
> +   *        A string name for that database.
> +   * @param aVersion

s/aVersion/aDbVersion

Comment 9

[Gene Lian (I already quit Mozilla)]

Comment on attachment 8336764 [details] [diff] [review]
part 3/3: test cases

Review of attachment 8336764 [details] [diff] [review]:
-----------------------------------------------------------------

This is awesome! Thanks!

::: dom/mobilemessage/tests/marionette/head.js
@@ +350,5 @@
> +
> +/* Initialize a MobileMessageDB.  Resolve if initialized with success, reject
> + * otherwise.
> + *
> + * Forfill params: a MobileMessageDB instance.

s/Forfill/Fullfill

@@ +361,5 @@
> + *        version.
> + *
> + * @return A deferred promise.
> + */
> +function initMobileMessageDB(aMmdb, aName, aVersion) {

Where is |@param aMmdb|?

@@ +381,5 @@
> + * @return The passed MobileMessageDB instance.
> + */
> +function closeMobileMessageDB(aMmdb) {
> +  aMmdb.close();
> +  return aMmdb;

Why need to return?

Comment 10

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Gene Lian [:gene] (needinfo? encouraged) from comment #9)
> ::: dom/mobilemessage/tests/marionette/head.js
> @@ +381,5 @@
> > + * @return The passed MobileMessageDB instance.
> > + */
> > +function closeMobileMessageDB(aMmdb) {
> > +  aMmdb.close();
> > +  return aMmdb;
> 
> Why need to return?

It was designed to be a handler for Promise.  Return value of a Promise handler becomes the argument for the next handler in chain.  So, returning the input argument here helps chaining up handlers easily.

However, bug 943233 prevents this easy setup due to some unknown exported js object unwrapping issue.  See there for details.

Comment 11

[Vicamo Yang [:vicamo][:vyang]]

Attachment: part 2.a/3: Changes to adopt MobileMessageDB.jsm : v2

rebase onto bug 942780.

Comment 12

[Vicamo Yang [:vicamo][:vyang]]

Attachment: part 2.b/3: Move init functions out of MobileMessage constructor : v2

address comment 8

Comment 13

[Vicamo Yang [:vicamo][:vyang]]

Attachment: part 3/3: test cases : v2

address comment 9.

Comment 14

[Vicamo Yang [:vicamo][:vyang]]

Will only land after v1.3 gets forked.

Comment 15

[Vicamo Yang [:vicamo][:vyang]]

Attachment: part 2.a/3: Changes to adopt MobileMessageDB.jsm : v3

Rebase after bug 946079, bug 945711

Comment 16

[Vicamo Yang [:vicamo][:vyang]]

Re-try all https://tbpl.mozilla.org/?tree=Try&rev=df63fc42cc58

Comment 17

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/1033175b536c
https://hg.mozilla.org/integration/b2g-inbound/rev/fbf36cc32d02
https://hg.mozilla.org/integration/b2g-inbound/rev/b50959566023
https://hg.mozilla.org/integration/b2g-inbound/rev/4ca61e6ae245

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1033175b536c
https://hg.mozilla.org/mozilla-central/rev/fbf36cc32d02
https://hg.mozilla.org/mozilla-central/rev/b50959566023
https://hg.mozilla.org/mozilla-central/rev/4ca61e6ae245