940940 - New XRay Goggles link doesnt activate but old Hackasaurus link does

Status: VERIFIED FIXED

(Webmaker Graveyard :: X-Ray Goggles, defect)

Description

[Kat Braybrooke [:codekat]]

Last night I ran a Train the Trainers at Tate Britain here in the UK to teach them how to use XRay Goggles to remix their digital collections. 

On my computer this works fine (Mac laptop) but on their Mac and PC desktops, going to the Tate Britain homepage at http://www.tate.org.uk/visit/tate-britain , we were unable to activate via the new XRay Goggles (at https://goggles.webmaker.org/en-US ). However, we were able to activate via the *old* Hackasaurus link (ie www.hackasaurus.org ). 

We tried this on several different laptops, computers etc, but it worked on none except mine. 

Not sure why this is an issue, but it's a big one! Especially when we're trying to show how easy the tool is to use at partner workshops ;) So, hoping someone can figure it out!

Comment 1

[Brett Gaylor [:brett]]

wat.  I can't reproduce that - but we gotta get to the bottom of that :(

Comment 2

[Brett Gaylor [:brett]]

Any idea what browsers they were running, Kat?

Any chance you could go back and get web consoles or other diagnostic means?  Or just get someone there on the phone while we live troubleshoot?

Comment 3

[Kat Braybrooke [:codekat]]

Yeah, sorry I can't reproduce it either. They're a very new partner working with us so I'd rather not have to ask them that - but if I'm back in the studio I'll do it myself. 

The browsers we tried installing the (new) add-on to were Safari and Firefox both. Computers were brand new fancy desktop Macs and a few equally new PCs.

Comment 4

[Jon Buckley [:jbuck]]

I can recreate this in my copy of Firefox:

[11:04:02.655] GET https://webmaker.org/undefined/strings/undefined/en-CA [HTTP/1.1 404 Not Found 129ms]
[11:04:02.730] "Localized Error: HTTP error 404"

Comment 5

[Jon Buckley [:jbuck]]

Looks like the problem is with localisation, I have an older version of the bookmark that looks like this:

javascript:(function(){var%20script=document.createElement('script');script.src='https://goggles.webmaker.org/webxray.js';script.className='webxray';document.body.appendChild(script);})();

If I visit the page now, it looks like:

javascript:(function(){var%20script=document.createElement('script');script.src='https://goggles.webmaker.org/en-CA/webxray.js';script.className='webxray';script.dataset.lang='en-CA';script.dataset.baseuri='https://goggles.webmaker.org/en-CA';document.body.appendChild(script);})();

Comment 6

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/goggles.webmaker.org/pull/65

Comment 7

[Ali Al Dallal [:alicoding]]

Comment on attachment 8336139 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/65

Tested and it's working now.

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/goggles.webmaker.org

https://github.com/mozilla/goggles.webmaker.org/commit/dfde3821ecf32d834251e7eb9f545ccd22dd388a
Fix bug 940940 - Default to en-US if no locale data set

Comment 9

[Jon Buckley [:jbuck]]

My old bookmark is working now. :codekat - Thanks for reporting this issue! :)